Use unsigned integer for shift count type (bazelbuild#258)

ClintonKildepstein · Aug 13, 2021 · 4dbbe54 · 4dbbe54
1 parent 0f006d8
commit 4dbbe54
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/httputil/httputil.go b/httputil/httputil.go
@@ -118,7 +118,7 @@ func getWaitPeriod(res *http.Response, attempt int) (time.Duration, error) {
 		}
 	}
 	// Let's just use exponential backoff: 1s + d1, 2s + d2, 4s + d3, 8s + d4 with dx being a random value in [0ms, 500ms]
-	return time.Duration(1 << attempt) * time.Second + time.Duration(rand.Intn(500)) * time.Millisecond, nil
+	return time.Duration(1 << uint(attempt)) * time.Second + time.Duration(rand.Intn(500)) * time.Millisecond, nil
 }
 
 func parseRetryHeader(value string) (time.Duration, error) {

diff --git a/httputil/httputil_test.go b/httputil/httputil_test.go
@@ -176,7 +176,7 @@ func TestShouldUseExponentialBackoffIfNoRetryHeader(t *testing.T) {
 	}
 
 	delta := time.Millisecond * 100
-	lower := (1 << retries) * time.Second
+	lower := (1 << uint(retries)) * time.Second
 	upper := lower + time.Duration(retries*500)*time.Millisecond
 	if total < lower-delta || upper+delta < total {
 		t.Fatalf("Expected a total sleep time between %s and %s (%d retries, exponential backoff with fuzzing), but waited %s instead", lower, upper, retries, total)