[MSVC] Fix workflow name, indent, name style.

Fix workflow name in `.github/workflows/reusable-build-on-windows-msvc.yml`. Fix indent in `test/CMakeLists.txt`. Fix variable name style in `include/common/int128.h`. Change from `leading_zero` to `LeadingZero`. Signed-off-by: Wang Jikai <[email protected]>
CloudBee7 · Sep 12, 2023 · 50778b1 · 50778b1
1 parent 7cc65d1
commit 50778b1
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/.github/workflows/reusable-build-on-windows-msvc.yml b/.github/workflows/reusable-build-on-windows-msvc.yml
@@ -1,4 +1,4 @@
-name: Build on Windows
+name: Build on Windows with MSVC
 
 on:
   workflow_call:

diff --git a/include/common/int128.h b/include/common/int128.h
@@ -282,14 +282,14 @@ class uint128_t {
   constexpr uint64_t high() const noexcept { return High; }
   constexpr unsigned int clz() const noexcept {
 #if defined(_MSC_VER) && !defined(__clang__)
-    unsigned long leading_zero = 0;
+    unsigned long LeadingZero = 0;
     if (High) {
-      _BitScanReverse64(&leading_zero, High);
-      return (63 - leading_zero);
+      _BitScanReverse64(&LeadingZero, High);
+      return (63 - LeadingZero);
     }
     if (Low) {
-      _BitScanReverse64(&leading_zero, Low);
-      return (63 - leading_zero) + 64;
+      _BitScanReverse64(&LeadingZero, Low);
+      return (63 - LeadingZero) + 64;
     }
     return 128;
 #else

diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
@@ -62,11 +62,11 @@ endif()
 
 if(CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
   set_property(
-      DIRECTORY
-      APPEND
-      PROPERTY COMPILE_OPTIONS
-      /wd4267 # conversion from 'size_t' to 'const uint32_t', possible loss of data
-      /wd4146 # unary minus operator applied to unsigned type, result still unsigned (`UINT32_C(-1)`)
+    DIRECTORY
+    APPEND
+    PROPERTY COMPILE_OPTIONS
+    /wd4267 # conversion from 'size_t' to 'const uint32_t', possible loss of data
+    /wd4146 # unary minus operator applied to unsigned type, result still unsigned (`UINT32_C(-1)`)
   )
 endif()