Skip to content

Commit

Permalink
Reviewed by: M. Ranganathan
Browse files Browse the repository at this point in the history
added ack for bug report.
  • Loading branch information
ranganathanm committed Jan 12, 2004
1 parent 5ed9447 commit f13daab
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 203 deletions.
205 changes: 3 additions & 202 deletions README
Original file line number Diff line number Diff line change
Expand Up @@ -131,214 +131,15 @@ Implementation Team
"Oliver Deruelle" <[email protected]>


SUBSTANTIAL CODE CONTRIBUTIONS MADE BY THE FOLLOWING PEOPLE
-----------------------------------------------------------

1. Emil Ivov <[email protected]> Contributed a Video Softphone Under GPL.

2. Emil Ivov contributed the TCK for the Transaction and Dialog layer - this
is over 75% of the TCK itself.

3. Jeff Keyser Contributed the Transaction layer to NIST-SIP 1.1 that was
ported to NIST-SIP 1.2. Jeff also suggested the architecture for
MessageProcessors and extensiblity that is a part of the implementation
architecture.

----------------------------------------------------------------------------

This code was developed in the Internetworking Technogies Group (ITG),
Advanced Networking Technogies Division (ANTD), the National Institute of
Standards and Technology (NIST).

Group Manager: Doug Montgomery <[email protected]>

Division Chief: David Su <[email protected]>

http://www-x.antd.nist.gov/

----------------------------------------------------------------------------

CHANGES from NIST-SIP 1.1
-------------------------
See the change list for differences between JAIN-SIP 1.0 and JAIN-SIP 1.1.

Significant implementation differences -

1. The NIST headers directly implement the JAIN headers.
2. Antlr is not used in the parser.
3. The class hierarchy for NIST SIP has been significantly altered.
Substantial input by early adopters and fearless users.

See List of Contributions at:

ACKNOWLEDGEMENTS
-----------------

Marc Bednarek and Christophe Chazeau were guest researchers at NIST when
NIST-SIP 1.0 and NIST-SIP 1.1 were in development. Their contributions
are acknowledged.

The JAIN-SIP 1.1 API design is largely based on the NIST implementation
experiences of JAIN-SIP 1.0. The contributions of Chris Harris
from DynamicSoft (Spec Lead for JAIN-SIP 1.0) are hereby gratefully
acknowledged.

Design contributions to JAIN SIP 1.1 API were made by:

Brian O'Neill and Josh Burger from Terminal Technologies inc.

Dave Ferry and Ben Evans from Open Cloud inc.

Brad Templeton suggested that Dialog.sendBye be changed to the more
generally useful Dialog.sendRequest.

Emil Ivov, Brad Templeton and others requested a method to create a cancel
and Ack request for a client transaction and consequently
ClientTransaction.createCancel was added to the API.
file:./www/README.html

----------------------------------------------------------------------------
Bug Reports and enhancements for NIST-SIP 1.2 were contributed
by the following people:

1. Brad Templeton noticed bugs in the Transaction/Dialog layer
Brad suggested that Dialog.sendBye be changed to a more general
Dialog.sendRequest Brad templeton noticed that the stack was
sending out a Trying immediately and thereby not giving the application
a chance to do so.

2. Emil Ivov Contributed IPV6 Support. Emil Cotributed the Video Softphone
under GPL Licensing. (See acknowledgement above). Emil noticed spec
documentation bugs. Emil uncovered bugs in the transaction layer
implementation for several corner cases. Emil and Iain Macdonnell from
Sun reported a problem with SDP parsing. Emil discovered a bug in the
Server transaction implementation. Emil contributed comprehensive
state machine unit tests of the Transaction layer to the TCK
(work in progress).

3. Andreas Bystr�m reported bugs in set/get methods for Authentication
headers (quotes were missing). Andreas reported bugs in the
SDP implementation. Andreas helped to unit test call flows. Andreas
found documentation bugs and reported problems and incompleteness with
the TCK. Andreas noticed problems with Acking 487. Ack should be sent
before the TU gets called. Andreas noted that CANCEL should not
contain content. Andreas noted that a dialog can change from client to
server in the middle of the dialog (for example client sends a re-invite
and puts caller on hold -- see sipping service examples draft). The
RI was not allowing this. This was fixed and tested by Andreas.

4. Antonis Karydas reported bugs in the implementation of the JAIN transaction
model. Server transactions were being created with non-null TID
on reciept of invites. Antonis reported that To/From headers should
not be restricted only to use SIP urls. Antonis reported that
route sets were not properly maintained in the DialogImpl. Antonis
reported that the DefaultRouterImplementation should be able to handle
NON-SIP URLs. Antonis fixed a bug in Dialog.sendRequest() and
Dialog.createRequest(). Antonis reported several bugs in the strategy
being used for dealing with ACKs for 4xx responses. Antonis reported
a problem in handling Server transaction timeouts and posted a fix
for this problem. Antonis reported a problem in content length for
generation of responses. Antonis reported a problem with closely
spaced ACKs for CANCELed Server Transactions. Antonis reported that
CANCEL after OK was not properly handled (stack should respond OK
to cancel and not bother application.

5. Beichuang reported bugs in the IM Client and presence server. BC also
noted that extension methods were not working (Dialogs were not being
created).

6. Steve Crossley reported bugs in the parser and setting local/remote party
of dialog layer. Steve contributed a fix to the next hop determination
in the Dialog code that could allow it to deal with legacy systems.
Steve noticed that the short form of Refer-To was not supported in
the parser. Steve noticed that null pointers were being generated
when SessionDescriptionImpl was being cloned with null fields.
Steve reported that content length was being set to 0 when the
content of the SIP message is specified as an Object.

7. Viswashanti Raj Kadiyala reported a bug and contributed a bug fix
in the initialization of the tcp message channel. Shanti also
reported a bug and contributed a bug fix for reciever tagging for
Via headers.

8. Andrew Prokop reported a bug in cloning of Authentication headers.

9. Bob Johnson noticed documentation bugs.

10. Mark Smith noticed that there were bugs in the handling of lr in the proxy.

12. Tiago Dias (Altitude software) noticed that there was a bug with
subscribe/notify processing in the proxy. Tiago noticed that
Notify processing in the proxy (presence extension)
was not returning final response immediately and contributed
a bug fix for the proxy that rectified the problem.

13. Roberto Tealdi reported a problem in instantiating multiple
stacks in multi-homed hosts.

14. Laurent Schwitzer noticed that events were being dropped (not delivered
to application) when request and response were closely spaced
in time. Laurent noticed that the recieved parameter was not
handling ipv6 address types.

15. Stuart Woodsford (British Telecom) noticed a bug in the parsing of host
names when there are more than 3 components in the host name.

16. Brian J. Collins discovered bugs in the implementation of SdpFactory.

17. Dekeyzer Dmitri < [email protected] > noted that
PRACK was not updating the Dialog state and therefore route sets
were not being applied appropriately.

18. Willem Romijn corrected the payload type constant for H.263 codecs
in SdpConstants.java


----------------------------------------------------------------------------

Following is a list of people who contributed bugs reports and fixes to
NIST-SIP 1.1 (which implemented the JAIN SIP 1.0 interefaces). Many of
these fixes carry over to NIST-SIP 1.2 and hence their contributions
are acknowledged in rough chronological order of first contribution.
Acknowledgements for contributions are listed below and in the code
where their contributions appear:

Chris Mills
Maria Yndefors
Stefan Foekel
Jakob Schlyter
Ganesh Jayadevan
Steven Lass
Kim Kirby
Andre Pharand
Christophe Lafaille
Gordon Ledgard
Robert Billingslea
Juan Fco. Martin
Ahmet Uyar
Prasanna Kumar
Lamine Brahimi
Nadeem Anwar
Andreas Bystr�m
Yann Duponchel
Thai Dang Vu
Will Scullin
Jeff Keyser
Robert M. Smith
S. Nageswara Rao
Niklas Uhrberg
Eero Vaarnas
Laurent Schweizer
M.P. Ardhanareeswaran
Stephen Jones
Espen Skjaeran
Scott Holben
Salva Rey Calatayd
Tsun-Chieh Chiang
Dan Timoney
Majdi Abuelbassal
Srinivas Maganti
R.W. Johnson
Emil Ivov



The following only applies to those parts of this distribution that
were developed at NIST.
Expand Down
5 changes: 4 additions & 1 deletion www/README.html
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ <h2> Acknowledgements </h2>
<p> Design contributions to JAIN SIP 1.1 API were made by:

<ul>
<li> Brian O'Neill and Josh Burger (currently at bvoice).
<li> Brian O'Neill and Josh Burger (currently at BaseVoice).

<li> Dave Ferry and Ben Evans from Open Cloud inc.

Expand Down Expand Up @@ -165,6 +165,9 @@ <h2> Acknowledgements </h2>

<li> Gareth Deli noticed a bug in TCP transport.

<li> Ben Evans noticed a transaction state machine implementation error
in SIPServerTransaction

</ul>


Expand Down

0 comments on commit f13daab

Please sign in to comment.