Skip to content

Commit

Permalink
Merge pull request google#1 from google/test_267425726
Browse files Browse the repository at this point in the history
Internal change
  • Loading branch information
mkanat authored Sep 5, 2019
2 parents 0a8243b + 47ea81e commit 7d38053
Show file tree
Hide file tree
Showing 13 changed files with 11 additions and 15 deletions.
2 changes: 1 addition & 1 deletion review/developer/cl-descriptions.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Writing good CL descriptions

[TOC]


A CL description is a public record of **what** change is being made and **why**
it was made. It will become a permanent part of our version control history, and
Expand Down
2 changes: 1 addition & 1 deletion review/developer/handling-comments.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# How to handle reviewer comments

[TOC]


When you've sent a CL out for review, it's likely that your reviewer will
respond with several comments on your CL. Here are some useful things to know
Expand Down
2 changes: 0 additions & 2 deletions review/developer/index.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# The CL author's guide to getting through code review

go/cl-author

The pages in this section contain best practices for developers going through
code review. These guidelines should help you get through reviews faster and
with higher-quality results. You don't have to read them all, but they are
Expand Down
2 changes: 1 addition & 1 deletion review/developer/small-cls.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Small CLs

[TOC]


## Why Write Small CLs? {#why}

Expand Down
2 changes: 1 addition & 1 deletion review/emergencies.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Sometimes there are emergency CLs that must pass through the entire code review
process as quickly as
possible.

[TOC]


## What Is An Emergency? {#what}

Expand Down
2 changes: 1 addition & 1 deletion review/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ At Google we use code review to maintain the quality of our code and products.
This documentation is the canonical description of Google's code review
processes and policies.

[TOC]


This page is an overview of our code review process. There are two other large
documents that are a part of this guide:
Expand Down
2 changes: 1 addition & 1 deletion review/reviewer/comments.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# How to write code review comments

[TOC]


## Summary

Expand Down
2 changes: 0 additions & 2 deletions review/reviewer/index.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# How to do a code review

go/code-reviewer

The pages in this section contain recommendations on the best way to do code
reviews, based on long experience. All together they represent one complete
document, broken up into many separate sections. You don't have to read them
Expand Down
2 changes: 1 addition & 1 deletion review/reviewer/looking-for.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# What to look for in a code review

[TOC]


Note: Always make sure to take into account
[The Standard of Code Review](standard.md) when considering each of these
Expand Down
2 changes: 1 addition & 1 deletion review/reviewer/navigate.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Navigating a CL in review

[TOC]


## Summary

Expand Down
2 changes: 1 addition & 1 deletion review/reviewer/pushback.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Handling pushback in code reviews

[TOC]


Sometimes a developer will push back on a code review. Either they will disagree
with your suggestion or they will complain that you are being too strict in
Expand Down
2 changes: 1 addition & 1 deletion review/reviewer/speed.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Speed of Code Reviews

[TOC]


## Why Should Code Reviews Be Fast? {#why}

Expand Down
2 changes: 1 addition & 1 deletion review/reviewer/standard.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# The Standard of Code Review

[TOC]


The primary purpose of code review is to make sure that the overall
code health of Google's code
Expand Down

0 comments on commit 7d38053

Please sign in to comment.