Skip to content

Commit

Permalink
Set default clone strategy & cron format for trident to snapshot (kub…
Browse files Browse the repository at this point in the history
…evirt#3209)

There's a bug in the trident CSI driver that causes a snapshot
to be left over following each CSI clone:
NetApp/trident#901
This is becoming a problem rapidly once one hits the snapshot limit per volume (golden image):
https://kb.netapp.com/onprem/ontap/os/Maximum_number_of_snapshots_supported_by_ONTAP

Signed-off-by: Alex Kalenyuk <[email protected]>
  • Loading branch information
akalenyu authored Apr 30, 2024
1 parent cd56b6c commit 55dd0d0
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions pkg/storagecapabilities/storagecapabilities.go
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,8 @@ var SourceFormatsByProvisionerKey = map[string]cdiv1.DataImportCronSourceFormat{
"openshift-storage.rbd.csi.ceph.com": cdiv1.DataImportCronSourceFormatSnapshot,
"topolvm.cybozu.com": cdiv1.DataImportCronSourceFormatSnapshot,
"topolvm.io": cdiv1.DataImportCronSourceFormatSnapshot,
"csi.trident.netapp.io/ontap-nas": cdiv1.DataImportCronSourceFormatSnapshot,
"csi.trident.netapp.io/ontap-san": cdiv1.DataImportCronSourceFormatSnapshot,
}

// CloneStrategyByProvisionerKey defines the advised clone strategy for a provisioner
Expand All @@ -129,14 +131,14 @@ var CloneStrategyByProvisionerKey = map[string]cdiv1.CDICloneStrategy{
"openshift-storage.rbd.csi.ceph.com": cdiv1.CloneStrategyCsiClone,
"cephfs.csi.ceph.com": cdiv1.CloneStrategyCsiClone,
"openshift-storage.cephfs.csi.ceph.com": cdiv1.CloneStrategyCsiClone,
"csi.trident.netapp.io/ontap-nas": cdiv1.CloneStrategyCsiClone,
"csi.trident.netapp.io/ontap-san": cdiv1.CloneStrategyCsiClone,
"pxd.openstorage.org/shared": cdiv1.CloneStrategyCsiClone,
"pxd.openstorage.org": cdiv1.CloneStrategyCsiClone,
"pxd.portworx.com/shared": cdiv1.CloneStrategyCsiClone,
"pxd.portworx.com": cdiv1.CloneStrategyCsiClone,
"topolvm.cybozu.com": cdiv1.CloneStrategyCsiClone,
"topolvm.io": cdiv1.CloneStrategyCsiClone,
"csi.trident.netapp.io/ontap-nas": cdiv1.CloneStrategySnapshot,
"csi.trident.netapp.io/ontap-san": cdiv1.CloneStrategySnapshot,
}

const (
Expand Down

0 comments on commit 55dd0d0

Please sign in to comment.