Support functions in default (react-native-community#333)

Collin3 · Apr 18, 2019 · c28fb93 · c28fb93
1 parent 98d88d5
commit c28fb93
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 5 deletions.
diff --git a/packages/cli/src/cliEntry.js b/packages/cli/src/cliEntry.js
@@ -125,7 +125,7 @@ const addCommand = (command: CommandT, ctx: ConfigT) => {
       opt.command,
       opt.description,
       opt.parse || defaultOptParser,
-      opt.default,
+      typeof opt.default === 'function' ? opt.default(ctx) : opt.default,
     ),
   );
 };

diff --git a/packages/cli/src/tools/config/schema.js b/packages/cli/src/tools/config/schema.js
@@ -22,7 +22,9 @@ const command = t.object({
       command: t.string().required(),
       description: t.string(),
       parse: t.func(),
-      default: t.alternatives().try([t.bool(), t.number(), t.string()]),
+      default: t
+        .alternatives()
+        .try([t.bool(), t.number(), t.string(), t.func()]),
     }),
   ),
   examples: t.array().items(

diff --git a/packages/platform-android/src/commands/runAndroid/index.js b/packages/platform-android/src/commands/runAndroid/index.js
@@ -362,7 +362,7 @@ export default {
       command: '--terminal [string]',
       description:
         'Launches the Metro Bundler in a new window using the specified terminal path.',
-      default: getDefaultUserTerminal(),
+      default: getDefaultUserTerminal,
     },
   ],
 };
diff --git a/packages/platform-ios/src/commands/runIOS/index.js b/packages/platform-ios/src/commands/runIOS/index.js
@@ -452,7 +452,7 @@ export default {
       command: '--terminal [string]',
       description:
         'Launches the Metro Bundler in a new window using the specified terminal path.',
-      default: getDefaultUserTerminal(),
+      default: getDefaultUserTerminal,
     },
   ],
 };
diff --git a/types/index.js b/types/index.js
@@ -10,7 +10,11 @@ export type CommandT = {
     command: string,
     description?: string,
     parse?: (val: string) => any,
-    default?: string | boolean | number,
+    default?:
+      | string
+      | boolean
+      | number
+      | ((ctx: ConfigT) => string | boolean | number),
   }>,
   examples?: Array<{
     desc: string,