Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown component with simple rules for native #67

Merged
merged 15 commits into from
Jul 20, 2020
Merged

Add markdown component with simple rules for native #67

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ff925b0
Add markdown components
KatPo Jun 9, 2020
a52ce0d
Ashoat's revisions
Ashoat Jul 9, 2020
1ae0995
Fix newline handling, hopefully for the last time
Ashoat Jul 14, 2020
b5b318b
[native] More fixes for Markdown rendering
Ashoat Jul 15, 2020
8984aa8
Make sure our artificial space we use for newline paragraphs is prope…
Ashoat Jul 15, 2020
7aa5211
Fix spacing between lines to match TextInput
Ashoat Jul 16, 2020
f0b563e
Simplify rules logic and introduce MarkdownRules type
Ashoat Jul 16, 2020
f85c4bb
[native] Replace hyperlink with custom markdown (#104)
KatPo Jul 16, 2020
4054c7b
Turn off link and autolink rule matching in inlineRules
Ashoat Jul 16, 2020
5d726ac
Prompt before opening link
Ashoat Jul 19, 2020
a582c90
Use style prop for Markdown component because it's hardcoded in NodeH…
Ashoat Jul 20, 2020
772088e
Forward props in Markdown component to Text component
Ashoat Jul 20, 2020
6eb2d68
Pass Markdown component to NodeHeightMeasurer
Ashoat Jul 20, 2020
317ad27
Explicitly set height in InnerTextMessage
Ashoat Jul 20, 2020
3a83313
Use default text rule from simple-markdown
Ashoat Jul 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use default text rule from simple-markdown
  • Loading branch information
@Ashoat
Ashoat committed Jul 20, 2020
commit 3a833133191d842fb073d2d0958919aaecb958ab
13 changes: 2 additions & 11 deletions native/markdown/rules.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,17 +88,8 @@ function inlineMarkdownRules(
</React.Fragment>
),
},
// This is the leaf node in the AST returned by the parse phase. We handle
// rendering emoji as a different size here
text: {
...SimpleMarkdown.defaultRules.text,
// eslint-disable-next-line react/display-name
react: (
node: SimpleMarkdown.SingleASTNode,
output: SimpleMarkdown.Output<string>,
state: SimpleMarkdown.State,
) => <React.Fragment key={state.key}>{node.content}</React.Fragment>,
},
// This is the leaf node in the AST returned by the parse phase
text: SimpleMarkdown.defaultRules.text,
};
return {
simpleMarkdownRules,
Expand Down