Skip to content

Commit

Permalink
Increase loaded accounts data size when padding program is used (#33219)
Browse files Browse the repository at this point in the history 
* Increase loaded accounts data size when padding program is used

* fix dos tool accordingly
  • Loading branch information
kirill lykov authored Sep 13, 2023
1 parent 1cc681d commit ec9b309
Show file tree
Hide file tree
Showing 5 changed files with 67 additions and 29 deletions.
58 changes: 40 additions & 18 deletions bench-tps/src/bench.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,18 @@ pub fn max_lamports_for_prioritization(compute_unit_price: &Option<ComputeUnitPr
u64::try_from(fee).unwrap_or(u64::MAX)
}

// set transfer transaction's loaded account data size to 30K - large enough yet smaller than
// 32K page size, so it'd cost 0 extra CU.
// In case of plain transfer transaction, set loaded account data size to 30K.
// It is large enough yet smaller than 32K page size, so it'd cost 0 extra CU.
const TRANSFER_TRANSACTION_LOADED_ACCOUNTS_DATA_SIZE: u32 = 30 * 1024;
// In case of padding program usage, we need to take into account program size
const PADDING_PROGRAM_ACCOUNT_DATA_SIZE: u32 = 28 * 1024;
fn get_transaction_loaded_accounts_data_size(enable_padding: bool) -> u32 {
if enable_padding {
TRANSFER_TRANSACTION_LOADED_ACCOUNTS_DATA_SIZE + PADDING_PROGRAM_ACCOUNT_DATA_SIZE
} else {
TRANSFER_TRANSACTION_LOADED_ACCOUNTS_DATA_SIZE
}
}

pub type TimestampedTransaction = (Transaction, Option<u64>);
pub type SharedTransactions = Arc<RwLock<VecDeque<Vec<TimestampedTransaction>>>>;
Expand Down Expand Up @@ -610,18 +619,18 @@ fn transfer_with_compute_unit_price_and_padding(
} else {
transfer_instruction
};
let mut instructions = vec![instruction];
let mut instructions = vec![
ComputeBudgetInstruction::set_loaded_accounts_data_size_limit(
get_transaction_loaded_accounts_data_size(instruction_padding_config.is_some()),
),
instruction,
];
if let Some(compute_unit_price) = compute_unit_price {
instructions.extend_from_slice(&[
ComputeBudgetInstruction::set_compute_unit_limit(TRANSFER_TRANSACTION_COMPUTE_UNIT),
ComputeBudgetInstruction::set_compute_unit_price(compute_unit_price),
])
}
instructions.extend_from_slice(&[
ComputeBudgetInstruction::set_loaded_accounts_data_size_limit(
TRANSFER_TRANSACTION_LOADED_ACCOUNTS_DATA_SIZE,
),
]);
let message = Message::new(&instructions, Some(&from_pubkey));
Transaction::new(&[from_keypair], message, recent_blockhash)
}
Expand Down Expand Up @@ -708,12 +717,12 @@ fn nonced_transfer_with_padding(
} else {
transfer_instruction
};
let mut instructions = vec![instruction];
instructions.extend_from_slice(&[
let instructions = vec![
ComputeBudgetInstruction::set_loaded_accounts_data_size_limit(
TRANSFER_TRANSACTION_LOADED_ACCOUNTS_DATA_SIZE,
get_transaction_loaded_accounts_data_size(instruction_padding_config.is_some()),
),
]);
instruction,
];
let message = Message::new_with_nonce(
instructions,
Some(&from_pubkey),
Expand Down Expand Up @@ -1028,13 +1037,21 @@ pub fn generate_and_fund_keypairs<T: 'static + BenchTpsClient + Send + Sync + ?S
funding_key: &Keypair,
keypair_count: usize,
lamports_per_account: u64,
enable_padding: bool,
) -> Result<Vec<Keypair>> {
let rent = client.get_minimum_balance_for_rent_exemption(0)?;
let lamports_per_account = lamports_per_account + rent;

info!("Creating {} keypairs...", keypair_count);
let (mut keypairs, extra) = generate_keypairs(funding_key, keypair_count as u64);
fund_keypairs(client, funding_key, &keypairs, extra, lamports_per_account)?;
fund_keypairs(
client,
funding_key,
&keypairs,
extra,
lamports_per_account,
enable_padding,
)?;

// 'generate_keypairs' generates extra keys to be able to have size-aligned funding batches for fund_keys.
keypairs.truncate(keypair_count);
Expand All @@ -1048,6 +1065,7 @@ pub fn fund_keypairs<T: 'static + BenchTpsClient + Send + Sync + ?Sized>(
keypairs: &[Keypair],
extra: u64,
lamports_per_account: u64,
enable_padding: bool,
) -> Result<()> {
let rent = client.get_minimum_balance_for_rent_exemption(0)?;
info!("Get lamports...");
Expand Down Expand Up @@ -1112,7 +1130,7 @@ pub fn fund_keypairs<T: 'static + BenchTpsClient + Send + Sync + ?Sized>(
total,
max_fee,
lamports_per_account,
TRANSFER_TRANSACTION_LOADED_ACCOUNTS_DATA_SIZE,
get_transaction_loaded_accounts_data_size(enable_padding),
);
}
Ok(())
Expand Down Expand Up @@ -1154,7 +1172,8 @@ mod tests {

let keypair_count = config.tx_count * config.keypair_multiplier;
let keypairs =
generate_and_fund_keypairs(client.clone(), &config.id, keypair_count, 20).unwrap();
generate_and_fund_keypairs(client.clone(), &config.id, keypair_count, 20, false)
.unwrap();

do_bench_tps(client, config, keypairs, None);
}
Expand All @@ -1169,7 +1188,8 @@ mod tests {
let rent = client.get_minimum_balance_for_rent_exemption(0).unwrap();

let keypairs =
generate_and_fund_keypairs(client.clone(), &id, keypair_count, lamports).unwrap();
generate_and_fund_keypairs(client.clone(), &id, keypair_count, lamports, false)
.unwrap();

for kp in &keypairs {
assert_eq!(
Expand All @@ -1193,7 +1213,8 @@ mod tests {
let rent = client.get_minimum_balance_for_rent_exemption(0).unwrap();

let keypairs =
generate_and_fund_keypairs(client.clone(), &id, keypair_count, lamports).unwrap();
generate_and_fund_keypairs(client.clone(), &id, keypair_count, lamports, false)
.unwrap();

for kp in &keypairs {
assert_eq!(client.get_balance(&kp.pubkey()).unwrap(), lamports + rent);
Expand All @@ -1209,7 +1230,8 @@ mod tests {
let lamports = 10_000_000;

let authority_keypairs =
generate_and_fund_keypairs(client.clone(), &id, keypair_count, lamports).unwrap();
generate_and_fund_keypairs(client.clone(), &id, keypair_count, lamports, false)
.unwrap();

let nonce_keypairs = generate_durable_nonce_accounts(client.clone(), &authority_keypairs);

Expand Down
18 changes: 13 additions & 5 deletions bench-tps/src/keypairs.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ pub fn get_keypairs<T>(
num_lamports_per_account: u64,
client_ids_and_stake_file: &str,
read_from_client_file: bool,
enable_padding: bool,
) -> Vec<Keypair>
where
T: 'static + BenchTpsClient + Send + Sync + ?Sized,
Expand Down Expand Up @@ -56,17 +57,24 @@ where
&keypairs,
keypairs.len().saturating_sub(keypair_count) as u64,
last_balance,
enable_padding,
)
.unwrap_or_else(|e| {
eprintln!("Error could not fund keys: {e:?}");
exit(1);
});
keypairs
} else {
generate_and_fund_keypairs(client, id, keypair_count, num_lamports_per_account)
.unwrap_or_else(|e| {
eprintln!("Error could not fund keys: {e:?}");
exit(1);
})
generate_and_fund_keypairs(
client,
id,
keypair_count,
num_lamports_per_account,
enable_padding,
)
.unwrap_or_else(|e| {
eprintln!("Error could not fund keys: {e:?}");
exit(1);
})
}
}
1 change: 1 addition & 0 deletions bench-tps/src/main.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,7 @@ fn main() {
*num_lamports_per_account,
client_ids_and_stake_file,
*read_from_client_file,
instruction_padding_config.is_some(),
);

let nonce_keypairs = if *use_durable_nonce {
Expand Down
2 changes: 2 additions & 0 deletions bench-tps/tests/bench_tps.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ fn test_bench_tps_local_cluster(config: Config) {
&config.id,
keypair_count,
lamports_per_account,
false,
)
.unwrap();

Expand Down Expand Up @@ -140,6 +141,7 @@ fn test_bench_tps_test_validator(config: Config) {
&config.id,
keypair_count,
lamports_per_account,
false,
)
.unwrap();
let nonce_keypairs = if config.use_durable_nonce {
Expand Down
17 changes: 11 additions & 6 deletions dos/src/main.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -550,12 +550,17 @@ fn create_payers<T: 'static + BenchTpsClient + Send + Sync>(
// transactions are built to be invalid so the the amount here is arbitrary
let funding_key = Keypair::new();
let funding_key = Arc::new(funding_key);
let res =
generate_and_fund_keypairs(client.unwrap().clone(), &funding_key, size, 1_000_000)
.unwrap_or_else(|e| {
eprintln!("Error could not fund keys: {e:?}");
exit(1);
});
let res = generate_and_fund_keypairs(
client.unwrap().clone(),
&funding_key,
size,
1_000_000,
false,
)
.unwrap_or_else(|e| {
eprintln!("Error could not fund keys: {e:?}");
exit(1);
});
res.into_iter().map(Some).collect()
} else {
std::iter::repeat_with(|| None).take(size).collect()
Expand Down

0 comments on commit ec9b309

Please sign in to comment.