Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use utf8 charset when encoding entities #1826

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

bachbui
Copy link
Contributor

@bachbui bachbui commented Dec 4, 2024

Use the UTF8 encoding mode when encoding entities in the HTML renderer. This things like Japanese characters won't be encoded but reserved HTML characters like <, >, & will still be

Use the UTF8 encoding mode when encoding entities in the HTML
renderer. This things like Japanese characters won't be encoded
but reserved HTML characters like <, >, & will still be
@dkorenblyum dkorenblyum marked this pull request as draft December 11, 2024 16:13
Copy link

@Naman-Kumar-Sinha Naman-Kumar-Sinha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@supeluri supeluri marked this pull request as ready for review December 13, 2024 09:03
@supeluri supeluri merged commit 6cf5d51 into main Dec 13, 2024
2 of 3 checks passed
@supeluri supeluri deleted the utf8-encoding branch December 13, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants