-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize SSZ collection tree creation #9088
base: master
Are you sure you want to change the base?
Conversation
Implements a more efficient approach to creating SSZ collection trees by using direct bottom-up tree construction instead of intermediate mutable copies. This optimization improves performance and memory efficiency when creating SSZ collections from lists of elements. The change eliminates the need for creating and modifying mutable copies, replacing it with a direct tree construction algorithm that builds the binary tree structure from the leaf nodes up.
Hey, thanks for raising. The spotless task is a gradle target I think we'd probably need to look at performance metrics (not sure if a JMH currently covers this) to demonstrate an improvement from this TODO before we'd look to merge this PR... |
Fixed |
Spotless still failing, are you still working on this? |
Spotless is alright now but some others are failing. Do I need to correct it too? |
basically now it's failing to compile, so for one |
I
Optimize SSZ collection tree creation
PR Description
Optimizes the
createTreeFromElements
method inSszCollectionSchema
by implementing a direct bottom-up tree construction approach instead of using intermediate mutable copies. This change improves performance and memory efficiency when creating SSZ collections.Key improvements:
Fixed Issue(s)
Addresses TODO comment in
SszCollectionSchema.java
about suboptimal method implementation.Documentation
Changelog