Skip to content

Commit

Permalink
posix-cpu-timers: Move prof/virt_ticks into caller
Browse files Browse the repository at this point in the history
The functions have only one caller left. No point in having them.

Move the almost duplicated code into the caller and simplify it.

Signed-off-by: Thomas Gleixner <[email protected]>
Reviewed-by: Frederic Weisbecker <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
  • Loading branch information
KAGA-KOKO committed Aug 28, 2019
1 parent 0476ff2 commit ab693c5
Showing 1 changed file with 9 additions and 21 deletions.
30 changes: 9 additions & 21 deletions kernel/time/posix-cpu-timers.c
Original file line number Diff line number Diff line change
Expand Up @@ -130,23 +130,6 @@ static inline int task_cputime_zero(const struct task_cputime *cputime)
return 0;
}

static inline u64 prof_ticks(struct task_struct *p)
{
u64 utime, stime;

task_cputime(p, &utime, &stime);

return utime + stime;
}
static inline u64 virt_ticks(struct task_struct *p)
{
u64 utime, stime;

task_cputime(p, &utime, &stime);

return utime;
}

static int
posix_cpu_clock_getres(const clockid_t which_clock, struct timespec64 *tp)
{
Expand Down Expand Up @@ -184,13 +167,18 @@ posix_cpu_clock_set(const clockid_t clock, const struct timespec64 *tp)
*/
static u64 cpu_clock_sample(const clockid_t clkid, struct task_struct *p)
{
u64 utime, stime;

if (clkid == CPUCLOCK_SCHED)
return task_sched_runtime(p);

task_cputime(p, &utime, &stime);

switch (clkid) {
case CPUCLOCK_PROF:
return prof_ticks(p);
return utime + stime;
case CPUCLOCK_VIRT:
return virt_ticks(p);
case CPUCLOCK_SCHED:
return task_sched_runtime(p);
return utime;
default:
WARN_ON_ONCE(1);
}
Expand Down

0 comments on commit ab693c5

Please sign in to comment.