Add null check for API data folder (QuantConnect#5774)

- Api.Initialize will not throw for null data folder. Adding unit test
Coulbe · Jul 16, 2021 · f75e81b · f75e81b
1 parent 522fe14
commit f75e81b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/Api/Api.cs b/Api/Api.cs
@@ -47,7 +47,7 @@ public class Api : IApi, IDownloadProvider
         public virtual void Initialize(int userId, string token, string dataFolder)
         {
             ApiConnection = new ApiConnection(userId, token);
-            _dataFolder = dataFolder.Replace("\\", "/", StringComparison.InvariantCulture);
+            _dataFolder = dataFolder?.Replace("\\", "/", StringComparison.InvariantCulture);
 
             //Allow proper decoding of orders from the API.
             JsonConvert.DefaultSettings = () => new JsonSerializerSettings

diff --git a/Tests/Api/ApiTests.cs b/Tests/Api/ApiTests.cs
@@ -69,6 +69,13 @@ public void ApiWillAuthenticate_InvalidCredentials_Unsuccessfully()
             Assert.IsFalse(api.Connected);
         }
 
+        [Test]
+        public void NullDataFolder()
+        {
+            var api = new Api.Api();
+            Assert.DoesNotThrow(() => api.Initialize(TestAccount, "", null));
+        }
+
         [TestCase("C:\\Data", "forex/oanda/daily/eurusd.zip")]
         [TestCase("C:\\Data\\", "forex/oanda/daily/eurusd.zip")]
         [TestCase("C:/Data/", "forex/oanda/daily/eurusd.zip")]