Skip to content

Commit

Permalink
fix detection for multiple VS installations
Browse files Browse the repository at this point in the history
In the case of multiple VS installations, a static variable wasn't
initialized. That led to wrong values in subsequent calls of the
detection function.

[ChangeLog][qtbase][qmake] fix detection for multiple VS installations

Task-number: QTBUG-35530
Change-Id: I3fc23bc99679fff640f39578a7074d16fe923334
Reviewed-by: Andy Shaw <[email protected]>
  • Loading branch information
Joerg Bornemann authored and The Qt Project committed Jan 8, 2014
1 parent 2b3f293 commit 46b397d
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions qmake/generators/win32/msvc_vcproj.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,10 @@ DotNET which_dotnet_version()
const QString productPath = installPaths.value(dotNetCombo[i].version);
if (productPath.isEmpty())
continue;
if (path.startsWith(productPath, Qt::CaseInsensitive))
return dotNetCombo[i].version;
if (path.startsWith(productPath, Qt::CaseInsensitive)) {
current_version = dotNetCombo[i].version;
return current_version;
}
}
}

Expand Down

0 comments on commit 46b397d

Please sign in to comment.