QAbstractItemModelTester: don't call match(QModelIndex(), ...)

The documentation for match() indicates that the index has to be valid since it determines which column to search in (in addition to "from which row"). So call match with a valid index, if the model isn't empty. Change-Id: I5f3754cf14d053bf04d207cefe7dcc938e0f4a5a Reviewed-by: Giuseppe D'Angelo <[email protected]>
CryFeiFei · Jun 27, 2018 · 4af292f · 4af292f
1 parent 27ea5a6
commit 4af292f
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/testlib/qabstractitemmodeltester.cpp b/src/testlib/qabstractitemmodeltester.cpp
@@ -322,9 +322,10 @@ void QAbstractItemModelTesterPrivate::nonDestructiveBasicTest()
     Qt::ItemFlags flags = model->flags(QModelIndex());
     MODELTESTER_VERIFY(flags == Qt::ItemIsDropEnabled || flags == 0);
     model->hasChildren(QModelIndex());
-    model->hasIndex(0, 0);
+    const bool hasRow = model->hasIndex(0, 0);
     QVariant cache;
-    model->match(QModelIndex(), -1, cache);
+    if (hasRow)
+        model->match(model->index(0, 0), -1, cache);
     model->mimeTypes();
     MODELTESTER_VERIFY(!model->parent(QModelIndex()).isValid());
     MODELTESTER_VERIFY(model->rowCount() >= 0);