fix potential stack overflow in Profile.jl (JuliaLang#31693)

Cthulhoni · Apr 12, 2019 · 6308ebd · 6308ebd
1 parent 1aa8c68
commit 6308ebd
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/stdlib/Profile/src/Profile.jl b/stdlib/Profile/src/Profile.jl
@@ -547,9 +547,13 @@ function tree!(root::StackFrameTree{T}, all::Vector{UInt64}, lidict::Union{LineI
         end
     end
     function cleanup!(node::StackFrameTree)
-        empty!(node.builder_key)
-        empty!(node.builder_value)
-        foreach(cleanup!, values(node.down))
+        stack = StackFrameTree[node]
+        while !isempty(stack)
+            node = pop!(stack)
+            empty!(node.builder_key)
+            empty!(node.builder_value)
+            append!(stack, values(node.down))
+        end
         nothing
     end
     cleanup!(root)