Skip to content

Commit

Permalink
[libjulia] correct soname to use only major version number (JuliaLang…
Browse files Browse the repository at this point in the history
…#38748)

The soname was changed in JuliaLang#38160 to be libjulia.so.1.6 instead of
libjulia.so.1, but probably not on purpose.

This contradicts what is written in the comment in Make.inc and it breaks
e.g. libcxxwrap_julia_jll which is linked against libjulia.so.1.
See JuliaPackaging/Yggdrasil#2233
  • Loading branch information
benlorenz authored Dec 7, 2020
1 parent 18b7fee commit aee7ec1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cli/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ endef
endif

$(build_shlibdir)/libjulia.$(JL_MAJOR_MINOR_SHLIB_EXT): $(LIB_OBJS) | $(build_shlibdir) $(build_libdir)
@$(call PRINT_LINK, $(CC) $(call IMPLIB_FLAGS,$@) $(LOADER_CFLAGS) -DLIBRARY_EXPORTS -shared $(SHIPFLAGS) $(LIB_OBJS) -o $@ $(LOADER_LDFLAGS) $(RPATH_LIB)) $(call SONAME_FLAGS,$(notdir $@))
@$(call PRINT_LINK, $(CC) $(call IMPLIB_FLAGS,$@) $(LOADER_CFLAGS) -DLIBRARY_EXPORTS -shared $(SHIPFLAGS) $(LIB_OBJS) -o $@ $(LOADER_LDFLAGS) $(RPATH_LIB)) $(call SONAME_FLAGS,libjulia.$(JL_MAJOR_SHLIB_EXT))
$(INSTALL_NAME_CMD)libjulia.$(SHLIB_EXT) $@
ifneq ($(OS), WINNT)
@ln -sf $(notdir $@) $(build_shlibdir)/libjulia.$(JL_MAJOR_SHLIB_EXT)
Expand Down

0 comments on commit aee7ec1

Please sign in to comment.