Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add accessibility improvements for target #7

Conversation

bryanrh29
Copy link

Pull Request

Description

Improve accessibility for target

Fixes (ticket link)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Verify that Carousel items that are video stories have an aria-label indicating the video will play once the item is click
  • Verify that when a story modal is open the story title is a h2 tag
  • Verify that you can navigate through the carousel items using the tab key
  • Verify that the aria-labels are showing the current index and the total amount of stories
  • Verify that after going through every item it goes to the next button
  • On the story modal, verify that the hr separator has aria-hidden enable

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…ty-improvements
@josuesantamaria josuesantamaria merged commit 096a414 into feature/stories-widget Jan 8, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants