SAK-31245 : Long instructor comments from Assignments don't display w…

…ell in student Gradebook view (sakaiproject#4237)
CuomoZ · Apr 19, 2017 · c74ba6b · c74ba6b
1 parent 90c630c
commit c74ba6b
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/gradebook/app/ui/src/webapp/css/gradebook.css b/gradebook/app/ui/src/webapp/css/gradebook.css
@@ -117,7 +117,12 @@ td.gbMessageAbove {vertical-align:top;}
 td.gbMessageAboveNumber {vertical-align:top; text-align:right; padding-right:2em !important;}
 
 /* Offset to better match icon and input heights. */
-.gbTextOnRow {margin-top:2px;}
+.gbTextOnRow {
+	margin-top: 2px;
+	max-height: 100px;
+	overflow-x: hidden;
+	overflow-y: scroll;
+}
 
 /* Try to make the standard message formatting work with other cell content. */
 .gbMessageAdjustForContent {margin-left:1px; margin-bottom:.5em;}

diff --git a/...bookng/tool/src/java/org/sakaiproject/gradebookng/tool/panels/GradeSummaryTablePanel.html b/...bookng/tool/src/java/org/sakaiproject/gradebookng/tool/panels/GradeSummaryTablePanel.html
@@ -55,7 +55,7 @@
 						</td>
 						<td wicket:id="weight"><!-- empty --></td>
 						<td class="gb-summary-grade-duedate" wicket:id="dueDate"></td>
-						<td class="gb-summary-grade-comments" wicket:id="comments"></td>
+						<td class="gb-summary-grade-comments"><div wicket:id="comments"></div></td>
 						<td class="gb-summary-grade-category" wicket:id="category"></td>
 					</tr>
 				</tbody>

diff --git a/gradebookng/tool/src/webapp/styles/gradebook-grades.css b/gradebookng/tool/src/webapp/styles/gradebook-grades.css
@@ -1188,3 +1188,10 @@ and (max-device-width : 736px) {
   font-family: "gradebook-icons";
   content: "\f071";
 }
+
+/* GradeSummayTablePanel - comments column */
+.gb-summary-grade-comments div{
+  overflow-y: scroll;
+  overflow-x: hidden;
+  max-height:100px;
+}