Skip to content

Commit

Permalink
[Impeller] Update API name to indicate descriptor set registrations. (f…
Browse files Browse the repository at this point in the history
…lutter#40922)

[Impeller] Update API name to indicate descriptor set registrations.
  • Loading branch information
chinmaygarde authored Apr 4, 2023
1 parent 13a18b9 commit 0e8faa9
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions impeller/renderer/pipeline_builder.h
Original file line number Diff line number Diff line change
Expand Up @@ -93,15 +93,15 @@ struct PipelineBuilder {
<< VertexShader::kLabel << "'.";
return false;
}
if (!vertex_descriptor->SetDescriptorSetLayouts(
if (!vertex_descriptor->RegisterDescriptorSetLayouts(
VertexShader::kDescriptorSetLayouts)) {
VALIDATION_LOG << "Cound not configure vertex descriptor set layout for"
" pipeline named '"
<< VertexShader::kLabel << "'.";
return false;
}

if (!vertex_descriptor->SetDescriptorSetLayouts(
if (!vertex_descriptor->RegisterDescriptorSetLayouts(
FragmentShader::kDescriptorSetLayouts)) {
VALIDATION_LOG << "Cound not configure vertex descriptor set layout for"
" pipeline named '"
Expand Down
2 changes: 1 addition & 1 deletion impeller/renderer/vertex_descriptor.cc
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ bool VertexDescriptor::SetStageInputs(
return true;
}

bool VertexDescriptor::SetDescriptorSetLayouts(
bool VertexDescriptor::RegisterDescriptorSetLayouts(
const DescriptorSetLayout desc_set_layout[],
size_t count) {
desc_set_layouts_.reserve(desc_set_layouts_.size() + count);
Expand Down
8 changes: 4 additions & 4 deletions impeller/renderer/vertex_descriptor.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,16 @@ class VertexDescriptor final : public Comparable<VertexDescriptor> {
}

template <size_t Size>
bool SetDescriptorSetLayouts(
bool RegisterDescriptorSetLayouts(
const std::array<DescriptorSetLayout, Size>& inputs) {
return SetDescriptorSetLayouts(inputs.data(), inputs.size());
return RegisterDescriptorSetLayouts(inputs.data(), inputs.size());
}

bool SetStageInputs(const ShaderStageIOSlot* const stage_inputs[],
size_t count);

bool SetDescriptorSetLayouts(const DescriptorSetLayout desc_set_layout[],
size_t count);
bool RegisterDescriptorSetLayouts(const DescriptorSetLayout desc_set_layout[],
size_t count);

const std::vector<ShaderStageIOSlot>& GetStageInputs() const;

Expand Down

0 comments on commit 0e8faa9

Please sign in to comment.