lib: Remove idtree from samba_util.h

No need to recompile the world when only a few files need this. Signed-off-by: Volker Lendecke <[email protected]> Reviewed-by: Jeremy Allison <[email protected]>
CynCYX · Jan 10, 2023 · b73ecb2 · b73ecb2
1 parent 743df90
commit b73ecb2
Show file tree

Hide file tree

Showing 18 changed files with 17 additions and 7 deletions.
diff --git a/examples/fuse/clifuse.c b/examples/fuse/clifuse.c
@@ -31,6 +31,7 @@
 #include "libcli/smb/smbXcli_base.h"
 #include "libcli/security/security.h"
 #include "clifuse.h"
+#include "lib/util/idtree.h"
 
 struct mount_state {
 	struct tevent_context *ev;

diff --git a/lib/util/samba_util.h b/lib/util/samba_util.h
@@ -589,9 +589,6 @@ int ms_fnmatch_protocol(const char *pattern, const char *string, int protocol,
 /** a generic fnmatch function - uses for non-CIFS pattern matching */
 int gen_fnmatch(const char *pattern, const char *string);
 
-#include "idtree.h"
-#include "idtree_random.h"
-
 #include "become_daemon.h"
 
 /**

diff --git a/lib/util/tests/idtree.c b/lib/util/tests/idtree.c
@@ -22,6 +22,7 @@
 #include "includes.h"
 #include "torture/torture.h"
 #include "torture/local/proto.h"
+#include "lib/util/idtree.h"
 
 static bool torture_local_idtree_simple(struct torture_context *tctx)
 {

diff --git a/libcli/cldap/cldap.c b/libcli/cldap/cldap.c
@@ -43,6 +43,7 @@
 #include "../librpc/gen_ndr/ndr_nbt.h"
 #include "../lib/util/asn1.h"
 #include "../lib/util/tevent_ntstatus.h"
+#include "lib/util/idtree_random.h"
 
 #undef strcasecmp
 

diff --git a/libcli/nbt/nbtsocket.c b/libcli/nbt/nbtsocket.c
@@ -27,6 +27,7 @@
 #include "lib/socket/socket.h"
 #include "librpc/gen_ndr/ndr_nbt.h"
 #include "param/param.h"
+#include "lib/util/idtree_random.h"
 
 #define NBT_MAX_REPLIES 1000
 

diff --git a/librpc/rpc/dcesrv_core.c b/librpc/rpc/dcesrv_core.c
@@ -34,6 +34,7 @@
 #include "librpc/gen_ndr/ndr_dcerpc.h"
 #include "lib/util/tevent_ntstatus.h"
 #include "system/network.h"
+#include "lib/util/idtree_random.h"
 
 /**
  * @file

diff --git a/source3/auth/auth_samba4.c b/source3/auth/auth_samba4.c
@@ -29,6 +29,7 @@
 #include "auth/gensec/gensec.h"
 #include "auth/credentials/credentials.h"
 #include "lib/global_contexts.h"
+#include "lib/util/idtree.h"
 
 #undef DBGC_CLASS
 #define DBGC_CLASS DBGC_AUTH

diff --git a/source3/libsmb/cli_smb2_fnum.c b/source3/libsmb/cli_smb2_fnum.c
@@ -43,6 +43,7 @@
 #include "ntioctl.h"
 #include "librpc/gen_ndr/ndr_quota.h"
 #include "lib/util/string_wrappers.h"
+#include "lib/util/idtree.h"
 
 struct smb2_hnd {
 	uint64_t fid_persistent;

diff --git a/source3/rpc_server/rpc_server.c b/source3/rpc_server/rpc_server.c
@@ -33,6 +33,7 @@
 #include "auth.h"
 #include "rpc_server/rpc_ncacn_np.h"
 #include "rpc_server/srv_pipe_hnd.h"
+#include "lib/util/idtree_random.h"
 
 #undef DBGC_CLASS
 #define DBGC_CLASS DBGC_RPC_SRV

diff --git a/source4/lib/messaging/messaging.c b/source4/lib/messaging/messaging.c
@@ -40,6 +40,7 @@
 #include "lib/messaging/messages_dgm_ref.h"
 #include "../source3/lib/messages_util.h"
 #include <tdb.h>
+#include "lib/util/idtree.h"
 
 /* change the message version with any incompatible changes in the protocol */
 #define IMESSAGING_VERSION 1

diff --git a/source4/nbt_server/interfaces.c b/source4/nbt_server/interfaces.c
@@ -30,7 +30,7 @@
 #include "lib/socket/netif.h"
 #include "param/param.h"
 #include "lib/util/util_net.h"
-
+#include "lib/util/idtree.h"
 
 /*
   receive an incoming request and dispatch it to the right place

diff --git a/source4/ntvfs/posix/pvfs_search.c b/source4/ntvfs/posix/pvfs_search.c
@@ -26,6 +26,7 @@
 #include "samba/service_stream.h"
 #include "lib/events/events.h"
 #include "../lib/util/dlinklist.h"
+#include "lib/util/idtree.h"
 
 /* place a reasonable limit on old-style searches as clients tend to
    not send search close requests */

diff --git a/source4/ntvfs/posix/vfs_posix.c b/source4/ntvfs/posix/vfs_posix.c
@@ -31,6 +31,7 @@
 #include "libcli/security/security.h"
 #include "lib/events/events.h"
 #include "param/param.h"
+#include "lib/util/idtree.h"
 
 /*
   setup config options for a posix share

diff --git a/source4/rpc_server/dcerpc_server.c b/source4/rpc_server/dcerpc_server.c
@@ -33,6 +33,7 @@
 #include "samba/process_model.h"
 #include "lib/util/samba_modules.h"
 #include "lib/util/tevent_ntstatus.h"
+#include "lib/util/idtree_random.h"
 
 /*
   take a reference to an existing association group

diff --git a/source4/smb_server/handle.c b/source4/smb_server/handle.c
@@ -19,7 +19,7 @@
 
 #include "includes.h"
 #include "smb_server/smb_server.h"
-
+#include "lib/util/idtree.h"
 
 /****************************************************************************
 init the handle structures

diff --git a/source4/smb_server/session.c b/source4/smb_server/session.c
@@ -21,7 +21,7 @@
 
 #include "includes.h"
 #include "smb_server/smb_server.h"
-
+#include "lib/util/idtree_random.h"
 
 /*
  * init the sessions structures

diff --git a/source4/smb_server/smb2/receive.c b/source4/smb_server/smb2/receive.c
@@ -29,7 +29,7 @@
 #include "ntvfs/ntvfs.h"
 #include "param/param.h"
 #include "auth/auth.h"
-
+#include "lib/util/idtree.h"
 
 /* fill in the bufinfo */
 void smb2srv_setup_bufinfo(struct smb2srv_request *req)

diff --git a/source4/smb_server/tcon.c b/source4/smb_server/tcon.c
@@ -24,6 +24,7 @@
 #include "samba/service_stream.h"
 #include "lib/tsocket/tsocket.h"
 #include "ntvfs/ntvfs.h"
+#include "lib/util/idtree_random.h"
 
 /****************************************************************************
 init the tcon structures