build and update changelog

bower.json

@@ -1,6 +1,6 @@
 {
     "name": "angular-smart-table",
-    "version": "1.4.13",
+    "version": "2.0.0",
     "homepage": "https://github.com/lorenzofox3/Smart-Table",
     "authors": [
         "lorenzofox3 <[email protected]>"

changeLog.md

@@ -114,3 +114,8 @@ function(tableState, tableController){
 * use a global configuration
 * expose filtered collection result
 
+## version 2.0.0
+
+* use interpolation rather than binding for st-search directive (to avoid the creation of isolated scope)
+
+**This is a breaking change as now, you will have to remove the single quote around the predicate property name, and if you were using a binding, you'll have to interpolate it with the curly brace notation**

package.json

@@ -1,6 +1,6 @@
 {
   "name": "angular-smart-table",
-  "version": "1.4.13",
+  "version": "2.0.0",
   "description": "",
   "main": "dist/smart-table.js",
   "scripts": {

src/stSearch.js

@@ -2,15 +2,13 @@ ng.module('smart-table')
   .directive('stSearch', ['stConfig', '$timeout', function (stConfig, $timeout) {
     return {
       require: '^stTable',
-      scope: {
-        predicate: '=?stSearch'
-      },
       link: function (scope, element, attr, ctrl) {
         var tableCtrl = ctrl;
         var promise = null;
         var throttle = attr.stDelay || stConfig.search.delay;
 
-        scope.$watch('predicate', function (newValue, oldValue) {
+
+        attr.$observe('stSearch', function (newValue, oldValue) {
           if (newValue !== oldValue) {
             ctrl.tableState().search = {};
             tableCtrl.search(element[0].value || '', newValue);
@@ -21,7 +19,7 @@ ng.module('smart-table')
         scope.$watch(function () {
           return ctrl.tableState().search;
         }, function (newValue, oldValue) {
-          var predicateExpression = scope.predicate || '$';
+          var predicateExpression = attr.stSearch || '$';
           if (newValue.predicateObject && newValue.predicateObject[predicateExpression] !== element[0].value) {
             element[0].value = newValue.predicateObject[predicateExpression] || '';
           }
@@ -33,8 +31,9 @@ ng.module('smart-table')
           if (promise !== null) {
             $timeout.cancel(promise);
           }
+
           promise = $timeout(function () {
-            tableCtrl.search(evt.target.value, scope.predicate || '');
+            tableCtrl.search(evt.target.value, attr.stSearch || '');
             promise = null;
           }, throttle);
         });

test/spec/stSearch.spec.js

@@ -38,7 +38,7 @@ describe('stSearch Directive', function () {
             var template = '<table st-table="rowCollection">' +
                 '<thead>' +
                 '<tr>' +
-                '<th><input st-search="\'name\'" /></th>' +
+                '<th><input st-search="name" /></th>' +
                 '<th><input st-search="" /></th>' +
                 '<th>age</th>' +
                 '</tr>' +
@@ -176,7 +176,7 @@ describe('stSearch Directive', function () {
             var template = '<table st-table="rowCollection">' +
                 '<thead>' +
                 '<tr>' +
-                '<th><input st-search="searchPredicate" /></th>' +
+                '<th><input st-search="{{searchPredicate}}" /></th>' +
                 '<th><input st-search="" /></th>' +
                 '<th>age</th>' +
                 '</tr>' +