Periodic fix issue111 #112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Think there may be a number of fixes here, but from the changelog:
Found an issue finding 3rd bounding galaxy for a hole when galaxies are colinear with the
hole center as in some synthetic datasets.
Changed Period Mode strategy to add an offset to existing galaxies instead of allocating
additional memory as new cells. May want to revisit strategy, but appears to be working well,
in non-periodic mode this offset should always be 0.0. VF on SDSS DR7 finds 900 voids now using the
example script.