Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add codegen support for std::function and std::optional #658

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

ab9rf
Copy link
Member

@ab9rf ab9rf commented Sep 12, 2023

support for std::function is currently halfassed, we only handle the return type for now but at least will let us get alignment correct

support for std::function is currently halfassed, we only handle the return type for now but at least will let us get alignment correct
@ab9rf ab9rf requested a review from lethosor September 12, 2023 07:03
@ab9rf ab9rf changed the title add support for std::function and std::optional add codegen support for std::function and std::optional Sep 12, 2023
@ab9rf
Copy link
Member Author

ab9rf commented Sep 12, 2023

hold on this while i add std::shared_ptr

@ab9rf ab9rf linked an issue Sep 12, 2023 that may be closed by this pull request
@cvuchener
Copy link
Contributor

Please update SYNTAX.rst when adding new types.

@ab9rf
Copy link
Member Author

ab9rf commented Sep 12, 2023

Please update SYNTAX.rst when adding new types.

that ship sailed three years ago, i'm afraid

@myk002 myk002 merged commit afa23ff into DFHack:master Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

add support for std::shared_ptr
3 participants