Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config): replace black,isort,flake and autoflake with ruff #55

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

ilkersigirci
Copy link
Contributor

@ilkersigirci ilkersigirci commented Feb 20, 2025

Replaces black,isort,flake and autoflake with ruff. With this addition, the project dev dependencies are simplified. The ruff package is 10-100x faster then its alternatives, hence running lint and format checks are easier and faster.

I have disabled some ruff rules in order to match with current behaviour of this project. There are tons of useful checks in the ruff, if requested ,they can be enabled in the pyproject.toml easily

Copy link

mergify bot commented Feb 20, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@dolfim-ibm dolfim-ibm self-requested a review February 20, 2025 12:04
@dolfim-ibm dolfim-ibm changed the title feat(config): replace black,isort,flake and autoflake with ruff chore(config): replace black,isort,flake and autoflake with ruff Feb 20, 2025
@dolfim-ibm
Copy link
Contributor

Thanks @ilkersigirci. Please sign-off your commit for contributing to this project.

Here are some guidelines:

To add your Signed-off-by line to every commit in this branch:

Ensure you have a local copy of your branch by checking out the pull request locally via command line.
In your local branch, run: git rebase HEAD~1 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin feature/add-ruff

@ilkersigirci ilkersigirci force-pushed the feature/add-ruff branch 4 times, most recently from 142c63d to 76540c0 Compare February 20, 2025 12:14
Signed-off-by: ilker.sigirci <[email protected]>
Signed-off-by: ilkersigirci <[email protected]>
Copy link
Contributor

@dolfim-ibm dolfim-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dolfim-ibm dolfim-ibm merged commit 36967f7 into DS4SD:main Feb 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants