Skip to content

Commit

Permalink
[TUIM-83] Upgrade CI and dev environments to Node 20 (#4679)
Browse files Browse the repository at this point in the history
  • Loading branch information
nawatts authored Feb 23, 2024
1 parent 4af250b commit a4b9cda
Show file tree
Hide file tree
Showing 9 changed files with 219 additions and 221 deletions.
5 changes: 3 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ executors:
node:
working_directory: /mnt/ramdisk
docker:
- image: cimg/node:18.10
- image: cimg/node:20.11
puppeteer:
working_directory: /mnt/ramdisk
docker:
- image: cimg/node:18.10-browsers
- image: cimg/node:20.11-browsers
gcloud:
working_directory: /mnt/ramdisk
docker:
Expand Down Expand Up @@ -277,6 +277,7 @@ jobs:
channel: "C7H40L71D" # dsde-qa-notify
integration-tests-pr-staging:
executor: puppeteer
resource_class: medium+
parallelism: 4
steps:
- integration-tests:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-pacts.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
- name: Set up Node
uses: actions/setup-node@v3
with:
node-version: 18
node-version: '~20.11'

- name: Install dependencies
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run-e2e-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: 18
node-version: '~20.11'

- name: Auth Lyle to GCP
id: 'lyle-auth'
Expand Down
18 changes: 9 additions & 9 deletions .hooks/plugin-warning-logger.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,16 @@ module.exports = {
factory: () => ({
hooks: {
validateProject() {
const nodeVersion = process.version
const expectedNodeVersion = '20.11';
const actualNodeVersion = process.version;

if (!nodeVersion.startsWith('v18.')) {
console.error('\x1b[1m' /* bold */ + '╔'.padEnd(79, '═') + '╗')
console.error(`║ Must be running node 18, you have ${nodeVersion}`.padEnd(79) + '║')
console.error('║ See https://nodejs.org/en/download/ for installation options'.padEnd(79) + '║')
console.error('╚'.padEnd(79, '═') + '╝')
console.error('\x1b[0m' /* not-bold */)

process.exit(1)
if (!actualNodeVersion.startsWith(`v${expectedNodeVersion}.`)) {
console.warn('\x1b[1m' /* bold */ + '╔'.padEnd(79, '═') + '╗');
console.warn(`║ You are using Node ${actualNodeVersion}.`.padEnd(79) + '║');
console.warn(`║ For consistency with CI environments, Node v${expectedNodeVersion} is recommended.`.padEnd(79) + '║');
console.warn('║ See https://nodejs.org/en/download/ for installation options'.padEnd(79) + '║');
console.warn('╚'.padEnd(79, '═') + '╝');
console.warn('\x1b[0m' /* not-bold */);
}
},
wrapScriptExecution(executor, project, locator, scriptName) {
Expand Down
2 changes: 1 addition & 1 deletion .pnp.loader.mjs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

402 changes: 201 additions & 201 deletions .yarn/releases/yarn-3.6.1.cjs → .yarn/releases/yarn-3.6.3.cjs

Large diffs are not rendered by default.

5 changes: 1 addition & 4 deletions .yarnrc.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
logFilters:
# don't need to warn that we're not running scripts for packages whose only script is attribution
# we've disabled their scripts to stop them being unplugged by yarn
- code: YN0005
level: discard

Expand Down Expand Up @@ -29,5 +27,4 @@ supportedArchitectures:
- darwin
- linux

yarnPath: .yarn/releases/yarn-3.6.1.cjs

yarnPath: .yarn/releases/yarn-3.6.3.cjs
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18.10
FROM node:20.11

COPY . /terra-ui/
RUN cd terra-ui \
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@
"built": false
}
},
"packageManager": "[email protected].1",
"packageManager": "[email protected].3",
"workspaces": [
"packages/*",
"integration-tests"
Expand Down

0 comments on commit a4b9cda

Please sign in to comment.