Bump Microsoft.CodeAnalysis.Analyzers from 3.3.4 to 3.11.0 in /tracer/src/Datadog.Trace.BenchmarkDotNet #6121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [Microsoft.CodeAnalysis.Analyzers](https://github.com/dotnet/roslyn-analyzers) from 3.3.4 to 3.11.0. - [Release notes](https://github.com/dotnet/roslyn-analyzers/releases) - [Changelog](https://github.com/dotnet/roslyn-analyzers/blob/main/PostReleaseActivities.md) - [Commits](https://github.com/dotnet/roslyn-analyzers/commits) --- updated-dependencies: - dependency-name: Microsoft.CodeAnalysis.Analyzers dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
area:benchmarks
Datadog ReportBranch report: ✅ 0 Failed, 362394 Passed, 2066 Skipped, 15h 44m 35.47s Total Time ⌛ Performance Regressions vs Default Branch (1)
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6121) - mean (70ms) : 67, 73
. : milestone, 70,
master - mean (71ms) : 67, 74
. : milestone, 71,
section CallTarget+Inlining+NGEN
This PR (6121) - mean (1,104ms) : 1085, 1123
. : milestone, 1104,
master - mean (1,109ms) : 1084, 1133
. : milestone, 1109,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6121) - mean (116ms) : 104, 127
. : milestone, 116,
master - mean (110ms) : 106, 114
. : milestone, 110,
section CallTarget+Inlining+NGEN
This PR (6121) - mean (787ms) : 761, 813
. : milestone, 787,
master - mean (777ms) : 762, 792
. : milestone, 777,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6121) - mean (94ms) : 90, 99
. : milestone, 94,
master - mean (93ms) : 90, 95
. : milestone, 93,
section CallTarget+Inlining+NGEN
This PR (6121) - mean (743ms) : 723, 763
. : milestone, 743,
master - mean (733ms) : 718, 748
. : milestone, 733,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6121) - mean (190ms) : 187, 193
. : milestone, 190,
master - mean (192ms) : 188, 195
. : milestone, 192,
section CallTarget+Inlining+NGEN
This PR (6121) - mean (1,201ms) : 1177, 1225
. : milestone, 1201,
master - mean (1,205ms) : 1183, 1227
. : milestone, 1205,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6121) - mean (276ms) : 272, 280
. : milestone, 276,
master - mean (280ms) : 266, 293
. : milestone, 280,
section CallTarget+Inlining+NGEN
This PR (6121) - mean (940ms) : 925, 956
. : milestone, 940,
master - mean (942ms) : 925, 959
. : milestone, 942,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6121) - mean (265ms) : 261, 269
. : milestone, 265,
master - mean (266ms) : 263, 270
. : milestone, 266,
section CallTarget+Inlining+NGEN
This PR (6121) - mean (929ms) : 913, 946
. : milestone, 929,
master - mean (933ms) : 915, 951
. : milestone, 933,
|
Benchmarks Report for tracer 🐌Benchmarks for #6121 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Slower
|
| Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 | 1.202 | 607.38 | 729.78 |
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 | 1.159 | 462.55 | 399.08 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 463ns | 0.188ns | 0.727ns | 0.00812 | 0 | 0 | 576 B |
| master | StartFinishSpan |
netcoreapp3.1 | 565ns | 0.448ns | 1.74ns | 0.00788 | 0 | 0 | 576 B |
| master | StartFinishSpan |
net472 | 608ns | 0.301ns | 1.17ns | 0.0917 | 0 | 0 | 578 B |
| master | StartFinishScope |
net6.0 | 473ns | 0.271ns | 1.05ns | 0.00973 | 0 | 0 | 696 B |
| master | StartFinishScope |
netcoreapp3.1 | 729ns | 0.47ns | 1.82ns | 0.00931 | 0 | 0 | 696 B |
| master | StartFinishScope |
net472 | 809ns | 0.491ns | 1.9ns | 0.104 | 0 | 0 | 658 B |
| #6121 | StartFinishSpan |
net6.0 | 399ns | 0.126ns | 0.472ns | 0.00813 | 0 | 0 | 576 B |
| #6121 | StartFinishSpan |
netcoreapp3.1 | 577ns | 0.537ns | 2.08ns | 0.00793 | 0 | 0 | 576 B |
| #6121 | StartFinishSpan |
net472 | 723ns | 3.55ns | 14.6ns | 0.0917 | 0 | 0 | 578 B |
| #6121 | StartFinishScope |
net6.0 | 483ns | 0.391ns | 1.41ns | 0.00967 | 0 | 0 | 696 B |
| #6121 | StartFinishScope |
netcoreapp3.1 | 713ns | 1.16ns | 4.48ns | 0.00962 | 0 | 0 | 696 B |
| #6121 | StartFinishScope |
net472 | 897ns | 0.705ns | 2.64ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 656ns | 0.36ns | 1.39ns | 0.00977 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 936ns | 0.689ns | 2.48ns | 0.00951 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.15μs | 0.35ns | 1.35ns | 0.105 | 0 | 0 | 658 B |
| #6121 | RunOnMethodBegin |
net6.0 | 652ns | 0.273ns | 1.06ns | 0.00977 | 0 | 0 | 696 B |
| #6121 | RunOnMethodBegin |
netcoreapp3.1 | 953ns | 1.8ns | 6.97ns | 0.00903 | 0 | 0 | 696 B |
| #6121 | RunOnMethodBegin |
net472 | 1.12μs | 0.222ns | 0.8ns | 0.104 | 0 | 0 | 658 B |
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6121) (10.993M) : 0, 10993192
master (11.026M) : 0, 11025824
benchmarks/2.9.0 (11.081M) : 0, 11080577
section Automatic
This PR (6121) (7.404M) : 0, 7404484
master (7.223M) : 0, 7222652
benchmarks/2.9.0 (7.732M) : 0, 7732233
section Trace stats
master (7.637M) : 0, 7637054
section Manual
master (11.033M) : 0, 11033388
section Manual + Automatic
This PR (6121) (6.777M) : 0, 6777255
master (6.838M) : 0, 6838100
section DD_TRACE_ENABLED=0
master (10.111M) : 0, 10110844
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6121) (9.763M) : 0, 9763046
master (9.545M) : 0, 9544888
benchmarks/2.9.0 (9.798M) : 0, 9798067
section Automatic
This PR (6121) (6.573M) : 0, 6572597
master (6.582M) : 0, 6582390
section Trace stats
master (7.056M) : 0, 7055697
section Manual
master (9.420M) : 0, 9419917
section Manual + Automatic
This PR (6121) (6.235M) : 0, 6234656
master (6.120M) : 0, 6119946
section DD_TRACE_ENABLED=0
master (8.969M) : 0, 8969486
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6121) (9.903M) : 0, 9902656
master (10.152M) : 0, 10151987
benchmarks/2.9.0 (10.067M) : 0, 10067315
section Automatic
This PR (6121) (6.770M) : 0, 6770362
master (6.883M) : 0, 6882713
benchmarks/2.9.0 (7.552M) : 0, 7552193
section Trace stats
master (7.424M) : 0, 7423517
section Manual
master (10.308M) : 0, 10308097
section Manual + Automatic
This PR (6121) (6.255M) : 0, 6254531
master (6.480M) : 0, 6479805
section DD_TRACE_ENABLED=0
master (9.556M) : 0, 9555959
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps Microsoft.CodeAnalysis.Analyzers from 3.3.4 to 3.11.0.
Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)