-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable 128bit trace ID logging by default #3116
base: v2-dev
Are you sure you want to change the base?
Conversation
BenchmarksBenchmark execution time: 2025-02-13 23:03:41 Comparing candidate commit f8ea041 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 1 unstable metrics. scenario:BenchmarkSetTagMetric-24
|
Datadog ReportBranch report: ❌ 7 Failed (0 Known Flaky), 4327 Passed, 67 Skipped, 2m 11s Total Time ❌ Failed Tests (7)
|
a7fe208
to
bcb6ad2
Compare
What does this PR do?
Logs contain the full 128bits of the trace id by default. Can be disabled with
DD_TRACE_128_BIT_TRACEID_LOGGING_ENABLED=false
. Feature applies to tracer logs as well as our supported logger integrations: slog and logrus.Motivation
Config consistency
Reviewer's Checklist
v2-dev
branch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!