-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/99designs/gqlgen: fix introspection query detection by checking Operation.Name #3175
Merged
darccio
merged 9 commits into
DataDog:main
from
LamineKouissi:fix-introspection-query-detection
Feb 20, 2025
Merged
contrib/99designs/gqlgen: fix introspection query detection by checking Operation.Name #3175
darccio
merged 9 commits into
DataDog:main
from
LamineKouissi:fix-introspection-query-detection
Feb 20, 2025
+28
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng Operation.Name
darccio
requested changes
Feb 11, 2025
rarguelloF
approved these changes
Feb 14, 2025
Hi @darccio @rarguelloF |
rarguelloF
approved these changes
Feb 17, 2025
Hi @rarguelloF, do I need to merge main into my PR every time there's a change, or can you handle that during the PR merge? |
darccio
approved these changes
Feb 18, 2025
Thanks @LamineKouissi for contributing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
contrib/99designs/gqlgen: fix introspection query detection by checking Operation.Name
Motivation
InterceptField() relied on OperationName to identify introspection queries. This was insufficient as valid introspection queries can have an unset OperationName while Operation.Name is set to IntrospectionQuery.
Could Fix #3085
Reviewer's Checklist
v2-dev
branch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!