Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] all: upgrade minimum supported Go release to 1.23 #3191

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

darccio
Copy link
Member

@darccio darccio commented Feb 17, 2025

What does this PR do?

With Go 1.24 released on 2025-02-11, we drop support for Go 1.22. This means Go 1.23 is now our minimum supported Go release. Update our CI files to reflect our current supported Go versions, and remove pre-Go 1.23 workarounds.

Motivation

Follow our declared Go support policy.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@darccio darccio requested review from a team as code owners February 17, 2025 16:02
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Feb 17, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 17, 2025

Datadog Report

Branch report: dario.castane/langplat-317/go-123-v2
Commit report: 7e81f16
Test service: dd-trace-go

❌ 15 Failed (0 Known Flaky), 4129 Passed, 66 Skipped, 2m 5.42s Total Time

❌ Failed Tests (15)

This report shows up to 5 failed tests.

  • TestDBMPropagation_PreventFullMode - github.com/DataDog/dd-trace-go/contrib/database/sql/v2 - Details

    Expand for error
     Failed
     
     === RUN   TestDBMPropagation_PreventFullMode
     --- FAIL: TestDBMPropagation_PreventFullMode (0.06s)
    
  • TestDBMPropagation_PreventFullMode/sqlserver-implicit-register - github.com/DataDog/dd-trace-go/contrib/database/sql/v2 - Details

    Expand for error
     Failed
     
     === RUN   TestDBMPropagation_PreventFullMode/sqlserver-implicit-register
         propagation_test.go:438: 
             	Error Trace:	/home/runner/work/dd-trace-go/dd-trace-go/contrib/database/sql/propagation_test.go:438
             	Error:      	Received unexpected error:
             	            	TLS Handshake failed: tls: failed to parse certificate from server: x509: negative serial number
             	Test:       	TestDBMPropagation_PreventFullMode/sqlserver-implicit-register
         --- FAIL: TestDBMPropagation_PreventFullMode/sqlserver-implicit-register (0.02s)
    
  • TestSqlServer - github.com/DataDog/dd-trace-go/contrib/database/sql/v2 - Details

    Expand for error
     Failed
     
     === RUN   TestSqlServer
     --- FAIL: TestSqlServer (0.01s)
    
  • TestSqlServer/Exec - github.com/DataDog/dd-trace-go/contrib/database/sql/v2 - Details

    Expand for error
     Failed
     
     === RUN   TestSqlServer/Exec
         sql.go:244: 
             	Error Trace:	/home/runner/work/dd-trace-go/dd-trace-go/instrumentation/testutils/sql/sql.go:244
             	Error:      	Not equal: 
             	            	expected: <nil>(<nil>)
             	            	actual  : *errors.errorString(&errors.errorString{s:"TLS Handshake failed: tls: failed to parse certificate from server: x509: negative serial number"})
             	Test:       	TestSqlServer/Exec
         --- FAIL: TestSqlServer/Exec (0.00s)
     ...
    
  • TestSQLServer - github.com/DataDog/dd-trace-go/contrib/gorm.io/gorm.v1/v2 - Details

    Expand for error
     
     2025/02/18 09:35:35 �[35m/home/runner/work/dd-trace-go/dd-trace-go/contrib/gorm.io/gorm.v1/gorm.go:57
     �[0m�[31m[error] �[0mfailed to initialize database, got error TLS Handshake failed: tls: failed to parse certificate from server: x509: negative serial number
     2025/02/18 09:35:35 TLS Handshake failed: tls: failed to parse certificate from server: x509: negative serial number
    

@darccio darccio changed the title all: upgrade minimum supported Go release to 1.23 [v2] all: upgrade minimum supported Go release to 1.23 Feb 18, 2025
@darccio darccio merged commit 35e3631 into v2-dev Feb 18, 2025
175 of 180 checks passed
@darccio darccio deleted the dario.castane/langplat-317/go-123-v2 branch February 18, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants