Skip to content

Commit

Permalink
ci: move botocore suite to gitlab (#12498)
Browse files Browse the repository at this point in the history
This change moves the `botocore` test suite to gitlab as part of the
ongoing migration away from circleci.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
  • Loading branch information
emmettbutler authored Feb 27, 2025
1 parent 7a52641 commit 3e1f211
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 9 deletions.
9 changes: 0 additions & 9 deletions .circleci/config.templ.yml
Original file line number Diff line number Diff line change
Expand Up @@ -393,15 +393,6 @@ jobs:
run_agent_checks: false
docker_services: "pygoat"

botocore:
<<: *machine_executor
parallelism: 6
steps:
- run_test:
pattern: 'botocore'
snapshot: true
docker_services: "localstack"

aiobotocore:
<<: *contrib_job
docker:
Expand Down
6 changes: 6 additions & 0 deletions .gitlab/services.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,12 @@
variables:
MAX_HEAP_SIZE: 512M
HEAP_NEWSIZE: 256M
localstack:
name: registry.ddbuild.io/images/mirror/localstack:1.4.0
alias: localstack
variables:
LAMBDA_EXECUTOR: local
DOCKER_HOST: unix:///var/run/docker.sock
mariadb:
name: registry.ddbuild.io/images/mirror/mariadb:lts
alias: mariadb
Expand Down
2 changes: 2 additions & 0 deletions tests/contrib/suitespec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,8 @@ suites:
pattern: ^botocore$
runner: riot
snapshot: true
services:
- localstack
bottle:
paths:
- '@bootstrap'
Expand Down

0 comments on commit 3e1f211

Please sign in to comment.