Skip to content

Commit

Permalink
chore: run the smoke test at the end of build_base_venvs (#12538)
Browse files Browse the repository at this point in the history
Example:
https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/825583009

## Checklist
- [X] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

---------

Signed-off-by: Juanjo Alvarez <[email protected]>
  • Loading branch information
juanjux authored Feb 27, 2025
1 parent 9aea2bb commit e344189
Show file tree
Hide file tree
Showing 8 changed files with 125 additions and 0 deletions.
18 changes: 18 additions & 0 deletions .riot/requirements/10e0b19.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
#
# This file is autogenerated by pip-compile with Python 3.11
# by the following command:
#
# pip-compile --allow-unsafe --no-annotate .riot/requirements/10e0b19.in
#
attrs==25.1.0
coverage[toml]==7.6.12
hypothesis==6.45.0
iniconfig==2.0.0
mock==5.1.0
opentracing==2.4.0
packaging==24.2
pluggy==1.5.0
pytest==8.3.4
pytest-cov==6.0.0
pytest-mock==3.14.0
sortedcontainers==2.4.0
20 changes: 20 additions & 0 deletions .riot/requirements/164d1f0.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
#
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
# pip-compile --allow-unsafe --no-annotate .riot/requirements/164d1f0.in
#
attrs==25.1.0
coverage[toml]==7.6.12
exceptiongroup==1.2.2
hypothesis==6.45.0
iniconfig==2.0.0
mock==5.1.0
opentracing==2.4.0
packaging==24.2
pluggy==1.5.0
pytest==8.3.4
pytest-cov==6.0.0
pytest-mock==3.14.0
sortedcontainers==2.4.0
tomli==2.2.1
20 changes: 20 additions & 0 deletions .riot/requirements/2377901.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
#
# This file is autogenerated by pip-compile with Python 3.9
# by the following command:
#
# pip-compile --allow-unsafe --no-annotate .riot/requirements/2377901.in
#
attrs==25.1.0
coverage[toml]==7.6.12
exceptiongroup==1.2.2
hypothesis==6.45.0
iniconfig==2.0.0
mock==5.1.0
opentracing==2.4.0
packaging==24.2
pluggy==1.5.0
pytest==8.3.4
pytest-cov==6.0.0
pytest-mock==3.14.0
sortedcontainers==2.4.0
tomli==2.2.1
20 changes: 20 additions & 0 deletions .riot/requirements/7ffd29a.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
#
# This file is autogenerated by pip-compile with Python 3.8
# by the following command:
#
# pip-compile --no-annotate .riot/requirements/7ffd29a.in
#
attrs==25.1.0
coverage[toml]==7.6.1
exceptiongroup==1.2.2
hypothesis==6.45.0
iniconfig==2.0.0
mock==5.1.0
opentracing==2.4.0
packaging==24.2
pluggy==1.5.0
pytest==8.3.4
pytest-cov==5.0.0
pytest-mock==3.14.0
sortedcontainers==2.4.0
tomli==2.2.1
18 changes: 18 additions & 0 deletions .riot/requirements/872f397.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
#
# This file is autogenerated by pip-compile with Python 3.13
# by the following command:
#
# pip-compile --allow-unsafe --no-annotate .riot/requirements/872f397.in
#
attrs==25.1.0
coverage[toml]==7.6.12
hypothesis==6.45.0
iniconfig==2.0.0
mock==5.1.0
opentracing==2.4.0
packaging==24.2
pluggy==1.5.0
pytest==8.3.4
pytest-cov==6.0.0
pytest-mock==3.14.0
sortedcontainers==2.4.0
18 changes: 18 additions & 0 deletions .riot/requirements/fc72580.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
#
# This file is autogenerated by pip-compile with Python 3.12
# by the following command:
#
# pip-compile --no-annotate .riot/requirements/fc72580.in
#
attrs==25.1.0
coverage[toml]==7.6.12
hypothesis==6.45.0
iniconfig==2.0.0
mock==5.1.0
opentracing==2.4.0
packaging==24.2
pluggy==1.5.0
pytest==8.3.4
pytest-cov==6.0.0
pytest-mock==3.14.0
sortedcontainers==2.4.0
9 changes: 9 additions & 0 deletions riotfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,15 @@ def select_pys(min_version: str = MIN_PYTHON_VERSION, max_version: str = MAX_PYT
)
],
),
Venv(
name="smoke_test",
command="python tests/smoke_test.py {cmdargs}",
venvs=[
Venv(
pys=select_pys(),
)
],
),
Venv(
name="ddtracerun",
command="pytest {cmdargs} --no-cov tests/commands/test_runner.py",
Expand Down
2 changes: 2 additions & 0 deletions scripts/gen_gitlab_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,8 @@ def gen_build_base_venvs() -> None:
apt update && apt install -y sccache
pip install riot==0.20.1
riot -P -v generate --python=$PYTHON_VERSION
echo "Running smoke tests"
riot -v run -s --python=$PYTHON_VERSION smoke_test
touch cache_used.txt
else
echo "Skipping build, using compiled files/venv from cache"
Expand Down

0 comments on commit e344189

Please sign in to comment.