GEODE-6177: WAN Event processing continues after authentication fails

Due to different handling in the GatewaySenderEventRemoteDispatcher dispatcher and ack reader threads, it was possible for event processing to stop when a GemFireSecurityException was encountered by the ack reader connection retry logic. This commit attempts to share common recoverable cases between the ack reader and dispatcher, while maintaining the cases which are specific to each. We also added a test which ensures that if a connection is denied due to invalid credentials upon a restart of the receiver, that the sender can recover if it again provides valid credentials. In the process, we removed a significant amount of duplicated and noisy code in the NewWanAuthenticationDUnitTests. Co-authored-by: Bill Burcham <[email protected]> Co-authored-by: Ryan McMahon <[email protected]>
DaveNutkins · Dec 17, 2018 · ea62d29 · ea62d29
1 parent deb8d1e
commit ea62d29
Show file tree

Hide file tree

Showing 3 changed files with 409 additions and 330 deletions.
diff --git a/geode-core/src/main/java/org/apache/geode/pdx/PdxRegistryMismatchException.java b/geode-core/src/main/java/org/apache/geode/pdx/PdxRegistryMismatchException.java
@@ -17,7 +17,7 @@
 import org.apache.geode.GemFireException;
 
 /**
- * Thrown when a an attempt is made to reuse a PDX Type. This can occur if the PDX registry files
+ * Thrown when an attempt is made to reuse a PDX Type. This can occur if the PDX registry files
  * are deleted from the sending side of a WAN Gateway.
  */
 public class PdxRegistryMismatchException extends GemFireException {