Skip to content

Commit

Permalink
SAK-31980 poi 3.15, Signup poi 3.14 (sakaiproject#4182)
Browse files Browse the repository at this point in the history
* SAK-31980 poi 3.15, Signup poi 3.14

* SAK-31980 Upgrade signup for newer POI

The pattern for creating a Hyperlink has changed so that now you use the creation helper associated with the workbook to create the links. This means signup can stay in sync with POI in the rest of Sakai.
  • Loading branch information
axxter99 authored and buckett committed Apr 28, 2017
1 parent 8c2745f commit 57ecb6b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion master/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@
<sakai.xerces.api.version>2.6.2</sakai.xerces.api.version>
<sakai.log4j.version>1.2.17</sakai.log4j.version>
<sakai.slf4j.version>1.7.21</sakai.slf4j.version>
<sakai.poi.version>3.14</sakai.poi.version>
<sakai.poi.version>3.15</sakai.poi.version>
<sakai.mockito.version>2.7.22</sakai.mockito.version>
<sakai.powermock.version>1.7.0RC4</sakai.powermock.version>
<sakai.okiosid.version>2.0</sakai.okiosid.version>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@

package org.sakaiproject.signup.tool.downloadEvents;

import org.apache.poi.common.usermodel.HyperlinkType;
import org.apache.poi.ss.util.CellRangeAddress;
import org.apache.poi.ss.usermodel.*;
import org.apache.poi.hssf.usermodel.HSSFHyperlink;
import org.apache.poi.hssf.usermodel.HSSFWorkbook;
import org.sakaiproject.exception.IdUnusedException;
import org.sakaiproject.signup.logic.SakaiFacade;
Expand Down Expand Up @@ -1063,8 +1063,8 @@ private String getSiteTitle(String siteId) {
return title;
}

private HSSFHyperlink setAttachmentURLLinks(SignupAttachment attach) {
HSSFHyperlink hsHyperlink = new HSSFHyperlink(HSSFHyperlink.LINK_URL);
private Hyperlink setAttachmentURLLinks(SignupAttachment attach) {
Hyperlink hsHyperlink = wb.getCreationHelper().createHyperlink(HyperlinkType.URL);
String link = this.sakaiFacade.getServerConfigurationService().getServerUrl()
+ attach.getLocation();
hsHyperlink.setAddress(link);
Expand Down

0 comments on commit 57ecb6b

Please sign in to comment.