Skip to content

Commit

Permalink
wifi: ath12k: fix debug messages
Browse files Browse the repository at this point in the history
In ath12k the debug messages were broken, no matter setting what value to the
debug_mask module parameter would not get the debug messages printed. The issue
is that __ath12k_dbg() uses dev_dbg() to print the debug messages which requires either enabling
CONFIG_DYNAMIC_DEBUG or DEBUG symbol in the driver.

ath12k is supposed to use debug_mask module to control whether debug messages
are printed or not. Using both CONFIG_DYNAMIC_DEBUG and debug_mask parameter
does not make any sense so switch to using dev_printk(), just like ath11k does.
Now it's enough just to debug_mask module parameter to get the debug messages.

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1

Signed-off-by: Kalle Valo <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
  • Loading branch information
kvalo committed Oct 5, 2023
1 parent 77f1ee6 commit 453a62a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/wireless/ath/ath12k/debug.c
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ void __ath12k_dbg(struct ath12k_base *ab, enum ath12k_debug_mask mask,
vaf.va = &args;

if (ath12k_debug_mask & mask)
dev_dbg(ab->dev, "%pV", &vaf);
dev_printk(KERN_DEBUG, ab->dev, "%pV", &vaf);

/* TODO: trace log */

Expand Down

0 comments on commit 453a62a

Please sign in to comment.