Skip to content

Commit

Permalink
Removed Content-Transfer-Encoding from the list of default download h…
Browse files Browse the repository at this point in the history
…eaders

`Content-Transfer-Encoding` is not a valid HTTP header (cf [RFC 7230, section 3.3.1](http://tools.ietf.org/html/rfc7230#section-3.3.1), [RFC 7231, section 8.3](http://tools.ietf.org/html/rfc7231#section-8.3), [IANA Message Header Registry](http://www.iana.org/assignments/message-headers/message-headers.xhtml)). The correct HTTP pendant would be `Transfer-Encoding: identity`, which were entirely bogus.
  • Loading branch information
DaSourcerer committed Jan 3, 2015
1 parent 81df332 commit 0cf4e74
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion framework/web/Response.php
Original file line number Diff line number Diff line change
Expand Up @@ -557,7 +557,6 @@ public function setDownloadHeaders($attachmentName, $mimeType = null, $inline =
->setDefault('Accept-Ranges', 'bytes')
->setDefault('Expires', '0')
->setDefault('Cache-Control', 'must-revalidate, post-check=0, pre-check=0')
->setDefault('Content-Transfer-Encoding', 'binary')
->setDefault('Content-Disposition', "$disposition; filename=\"$attachmentName\"");

if ($mimeType !== null) {
Expand Down

0 comments on commit 0cf4e74

Please sign in to comment.