10218 - Fix for session regenerate id issue that occured after user l…

…ogged out yiisoft#10218

framework/web/Session.php

@@ -182,7 +182,9 @@ public function destroy()
     {
         if ($this->getIsActive()) {
             @session_unset();
+            $sessionId = session_id();
             @session_destroy();
+            @session_id($sessionId);
         }
     }
 

tests/framework/web/SessionTest.php

@@ -0,0 +1,30 @@
+<?php
+
+namespace yiiunit\framework\web;
+
+use yii\web\Session;
+use yiiunit\TestCase;
+
+/**
+ * @group web
+ */
+class SessionTest extends TestCase
+{
+    /**
+     * Test to prove that Session::destroy generates session with new identifier
+     */
+    public function testDestroySessionId()
+    {
+        $session = new Session();
+        $session->open();
+        $oldSessionId = @session_id();
+
+        $this->assertNotEmpty($oldSessionId);
+
+        $session->destroy();
+
+        $newSessionId = @session_id();
+        $this->assertNotEmpty($newSessionId);
+        $this->assertEquals($oldSessionId, $newSessionId);
+    }
+}