Cgns module is updated by merging the best features of Bojan's code and earlier salome support branch #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
releases of mpich and openmpi lib and then use them to compile Process It is useful to determine supported versions of mpi implementations
Now it should work with Convert. Some headers .h also were updated if significantly changed.
with into cgns_branch_october_merged_with_salome_feature from egor
DelNov#111 Thus, I am trying to merge those changes from salome_feature branch into development branch. This is the first commit to adopt that branch for Convert. This commit is safe for Tests/Meshes/* test cases. Majority of edits updates visual output in verbose mode. Parallel mode now does not have Boundary conditions and Interfaces support since they are used only in Convert.
Still safe for Tests/Meshes/*
but I have to separate it from Bojan's way to restore ParentData. This commit works perfect with the channel test case from SALOME. This commit is NOT safe for Tests/Meshes/*
This commit is safe for Tests/Meshes/*
as Convert test case in Tests/Meshes/
palkinev
changed the title
Niceno
approved these changes
Oct 7, 2019
palkinev
deleted the
cgns_branch_october_merged_with_development_branch_on_7_oct
branch
palkinev
restored the
cgns_branch_october_merged_with_development_branch_on_7_oct
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know I can skip pull request in case of development branch, but I wanted everyone to be notified about it.
On November 2018 @mhadziabdic addressed me with request to add support for simple meshes from Salome opensource French mesher.
I worked on that issue and corresponding pull request #111 was approved on 17 of February 2019.
But it was never merged into the code.
From that pull request and its detailed description you can see that most of issues I had to deal with, when I was working with Salome mesh, appeared again recently when you had to convert meshes from ANSYS:
Even though you may never use Salome mesher, I believe that I lot of features I implemented back then can be useful today.
I desided to use Bojan's @Niceno version of Find_Parents.f90 since it is more robust than mine.
All tests cases in Tests/Meshes/ execute flawlessly.
Other improvements: