Simplifying getColumnNames logic (can be an array_map call)

Deltachaos · Dec 11, 2015 · 044b202 · 044b202
1 parent b2a6f8a
commit 044b202
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php b/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php
@@ -1873,17 +1873,11 @@ public function hasField($fieldName)
      */
     public function getColumnNames(array $fieldNames = null)
     {
-        if ($fieldNames === null) {
+        if (null === $fieldNames) {
             return array_keys($this->fieldNames);
         }
 
-        $columnNames = array();
-
-        foreach ($fieldNames as $fieldName) {
-            $columnNames[] = $this->getColumnName($fieldName);
-        }
-
-        return $columnNames;
+        return array_values(array_map([$this, 'getColumnName'], $fieldNames));
     }
 
     /**