Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync uber/RIBs v0.13.0 #4

Merged
merged 2 commits into from
May 1, 2022
Merged

Sync uber/RIBs v0.13.0 #4

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59eccf9
Fix typos
DevYeom May 1, 2022
bece9c4
Update version
DevYeom May 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix typos
  • Loading branch information
@DevYeom
DevYeom committed May 1, 2022
commit 59eccf94c40db942626d213c4358fe9e724ca3d6
2 changes: 1 addition & 1 deletion ModernRIBs/Classes/ComponentizedBuilder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ open class SimpleComponentizedBuilder<Component, Router>: ComponentizedBuilder<C
/// - parameter component: The corresponding DI component to use.
/// - returns: The router of the RIB.
open func build(with component: Component) -> Router {
fatalError("This method should be oevrriden by the subclass.")
fatalError("This method should be overriden by the subclass.")
}

/// Build a new instance of the RIB.
Expand Down
2 changes: 1 addition & 1 deletion ModernRIBs/Classes/Interactor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ open class Interactor: Interactable {
isActiveSubject.send(false)
}

/// Callend when the `Interactor` will resign the active state.
/// Called when the `Interactor` will resign the active state.
///
/// This method is driven by the detachment of this interactor's owner router. Subclasses should override this
/// method to cleanup any resources and states of the `Interactor`. The default implementation does nothing.
Expand Down