Remove html-truncate, truncate with CSS instead (github#17630)

* Remove html-truncate, truncate with CSS instead * Update search.js
DeveloperHidden · Feb 2, 2021 · e07c603 · e07c603
1 parent bbd54fe
commit e07c603
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 12 deletions.
diff --git a/javascripts/search.js b/javascripts/search.js
@@ -1,9 +1,6 @@
 import { tags } from './hyperscript'
 import { sendEvent } from './events'
 import searchWithYourKeyboard from 'search-with-your-keyboard'
-import truncate from 'html-truncate'
-
-const maxContentLength = 300
 
 let $searchInputContainer
 let $searchResultsContainer
@@ -274,8 +271,7 @@ function tmplSearchResult ({ url, breadcrumbs, heading, title, content }) {
       ),
       div(
         { class: 'search-result-content d-block text-gray' },
-        // Truncate without breaking inner HTML tags
-        markify(truncate(content, maxContentLength))
+        markify(content)
       )
     )
   )

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -57,7 +57,6 @@
     "highlightjs-graphql": "^1.0.2",
     "hot-shots": "^8.2.0",
     "html-entities": "^1.2.1",
-    "html-truncate": "^1.2.2",
     "imurmurhash": "^0.1.4",
     "ioredis": "^4.19.4",
     "ioredis-mock": "^5.2.0",

diff --git a/script/check-deps.js b/script/check-deps.js
@@ -42,7 +42,6 @@ const main = async () => {
       'style-loader',
       'webpack-cli',
       'browser-date-formatter',
-      'html-truncate',
       'search-with-your-keyboard',
       'uuid',
       'imurmurhash',

diff --git a/stylesheets/search.scss b/stylesheets/search.scss
@@ -89,6 +89,11 @@ mark,
   }
 }
 
+.search-result-content {
+  max-height: 4rem;
+  overflow: hidden;
+}
+
 .search-result-title em {
   font-style: normal;
   text-decoration: underline;