Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support Android 12 for the minicap.so building. #30

Merged
merged 2 commits into from
Oct 13, 2021
Merged

support Android 12 for the minicap.so building. #30

merged 2 commits into from
Oct 13, 2021

Conversation

JesseCodeBones
Copy link

No description provided.

@JesseCodeBones JesseCodeBones mentioned this pull request Oct 12, 2021
Open
varundtsfi
varundtsfi reviewed Oct 12, 2021
View reviewed changes
Copy link
Collaborator

@varundtsfi varundtsfi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JesseCodeBones changes regarding minicap_31.cpp is working fine. I have used his small piece of code where i was stuck. Its working fine. I will share the minicap.so file for arm64_v8a and armeabi_v7a soon.
@koral-- and @pcrepieux we have go ahead with @JesseCodeBones changes.

varundtsfi
varundtsfi reviewed Oct 12, 2021
View reviewed changes
Copy link
Collaborator

@varundtsfi varundtsfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are working fine. I have tested on Pixel 3 XL.

@pcrepieux
Copy link

Thanks guys for the PR. I was giving a look to #29 this morning.
@JesseCodeBones, may I ask you to update the main Makefile and fix the blank line. That would be nice. You also have to add a sign-off.
Otherwise, works great on my Pixel3XL as well 👍

@pcrepieux pcrepieux mentioned this pull request Oct 12, 2021
Closed
@koral--
Copy link
Member

koral-- commented Oct 12, 2021

Only sign-of is missing now

@JesseCodeBones JesseCodeBones force-pushed the Android_12_so_support branch 3 times, most recently from 395ce54 to cd704cf Compare October 13, 2021 03:47
@JesseCodeBones
Copy link
Author

@pcrepieux @koral--
I added the commits and signed off the commits.
and I also mentioned there missed the Android 30 and apart of Android 29.
I think it is not suitable to fix in this PR, maybe another PR is needed.
please kindly review the code and verify the result. Thank you very much.

@koral-- koral-- merged commit accda99 into DeviceFarmer:master Oct 13, 2021
childnode
childnode reviewed Jan 26, 2023
View reviewed changes
jni/minicap-shared/aosp/src/minicap_31.cpp
MCINFO("Creating virtual display");
mVirtualDisplay = android::SurfaceComposerClient::createDisplay(
/* const String8& displayName */ android::String8("minicap"),
/* bool secure */ false
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fails #34 and has to be set to true!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I see #34 (comment)

setting this to true will not help anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varundtsfi varundtsfi varundtsfi left review comments

@childnode childnode childnode left review comments

@koral-- koral-- koral-- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JesseCodeBones @pcrepieux @koral-- @childnode @varundtsfi