This repository has been archived by the owner on Oct 8, 2023. It is now read-only.
Sourcery refactored main branch #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| ss = "" | ||
| for sentence in sentences: | ||
| ss += sentence + "\n" | ||
| ss = "".join(sentence + "\n" for sentence in sentences) |
There was a problem hiding this comment.
Function TextDetectorGUI.update refactored with the following changes:
- Use str.join() instead of for loop (
use-join)
Comment on lines
-168
to
+173
| filename = os.path.join("./known_faces/", name + ".jpg") | ||
| filename = os.path.join("./known_faces/", f"{name}.jpg") | ||
| if os.path.exists(filename): | ||
| return tk.messagebox.showerror( | ||
| "Error", "A face with this name already exists." | ||
| ) | ||
| # Show a pop-up message | ||
| resp = tk.messagebox.askokcancel( | ||
| if resp := tk.messagebox.askokcancel( | ||
| "Cheese", "Smile for the camera! Click OK to click and image." | ||
| ) | ||
| if resp: | ||
| ): |
There was a problem hiding this comment.
Function SaveFaceGUI.save_face refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression) - Use f-string instead of string concatenation (
use-fstring-for-concatenation)
This removes the following comments ( why? ):
# Show a pop-up message
Comment on lines
-13
to
+16
| data_dir + "/shape_predictor_68_face_landmarks.dat" | ||
| f"{data_dir}/shape_predictor_68_face_landmarks.dat" | ||
| ) | ||
| face_recognition_model = dlib.face_recognition_model_v1( | ||
| data_dir + "/dlib_face_recognition_resnet_model_v1.dat" | ||
| f"{data_dir}/dlib_face_recognition_resnet_model_v1.dat" |
There was a problem hiding this comment.
Lines 13-16 refactored with the following changes:
- Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation)
| return person_names[min_index] + "?" + " ({0:.2f})".format(min_value) | ||
| return f"{person_names[min_index]}?" + " ({0:.2f})".format(min_value) |
There was a problem hiding this comment.
Function find_match refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
| data_dir + "/haarcascade_frontalface_default.xml" | ||
| f"{data_dir}/haarcascade_frontalface_default.xml" |
There was a problem hiding this comment.
Function recognize_faces_in_frame refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation) - Use named expression to simplify assignment and conditional (
use-named-expression)
Comment on lines
-55
to
+57
| data = [] | ||
| image = Image.fromarray(img) | ||
| image = image.resize((30, 30)) | ||
| data.append(np.array(image)) | ||
| data = [np.array(image)] |
There was a problem hiding this comment.
Function image_processing refactored with the following changes:
- Move assignment closer to its usage within a block (
move-assign-in-block) - Merge append into list declaration (
merge-list-append)
| sentences = [" ".join(s) for s in sentences] | ||
|
|
||
| return sentences | ||
| return [" ".join(s) for s in sentences] |
There was a problem hiding this comment.
Function group_words_to_sentences refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!