Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Navbar_1 #21

Closed
wants to merge 6 commits into from
Closed

Conversation

AnuragParashar2000
Copy link

No description provided.

@ghost ghost requested a review from Ovenoboyo December 12, 2021 14:06
@Ovenoboyo
Copy link
Member

@AnuragParashar2000 there are a few changes we would like you to carry out before we merge this PR.

  • Please use lowercase letters when naming directories or files
  • Avoid special characters like _ and numbers when naming files
  • Make use of props instead of hard-coded stuff (in your case it would be the navbar links and their titles)
  • Instead of react-icons or any other icon library, make use of slots
  • Please provide us with an example of your component implemented in example folder

@Ovenoboyo
Copy link
Member

Also your PR is failing our CI build

Copy link
Member

@Ovenoboyo Ovenoboyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check previous comments for changes

@AnuragParashar2000
Copy link
Author

AnuragParashar2000 commented Dec 12, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants