Modified MachineConfig Pydantic model: Turned the 'create_directories' field from a dict to a list #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #429 +/- ##
=======================================
Coverage 27.29% 27.29%
=======================================
Files 78 78
Lines 10182 10182
Branches 1358 1358
=======================================
Hits 2779 2779
Misses 7308 7308
Partials 95 95 |
d-j-hatton
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking through the Murfey source code, there doesn't appear to be a single instance where the keys of the dictionary in the
create_directoriesfield come into play. This PR simplifies theMachineConfigPydantic model by changing the dictionary into a list instead.