Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker-compose and ENV #41

Closed
wants to merge 2 commits into from
Closed

Conversation

cryptton2004
Copy link

@cryptton2004 cryptton2004 commented Feb 20, 2021

Hello,

I modified the project a lil' bit to support the usage of an .env file where you could store passwords and such.
Also created the docker-compose file for people using the composer (just seems faster for me to jump in a repo and hit: docker-compose up -d)
This required:

  • addition of a .env-sample
  • touched Dockerfile to add variables support
  • addition of a docker-compose.yml file with sample data already filled in.
  • modification of the readme file

However:
The are other commits that I've made over time included in this merge request that are not necessarily needed, like:

  • modification of ENV SEVEN_DAYS_TO_DIE_START_MODE to "2" in Dockerfile
  • modification of docker_run.ps1 to fit my needs
  • modification of echo "Running as user : $(whoami)" - added an extra space.
  • exposing ports 8080 and 8081. This is required if you have mods or apps that interact with your server. Like discord bots or server managers. They are directly linked with the requirements of THOSE projects, not this one.

I either did not want to change those in my repo since I use them (variables) or I did not want to cherry pick where I added extra spaces if the effort is not required. Thus, I'm submitting this 'as is'. Works fine on my instances. Might serve as inspiration to others even if this gets rejected. I see that you don't use .ENV on your dedicated server projects but having this would provide a higher level of abstractization and allow you to recycle stuff easier (like the Valheim server).

…use I have no idea why I changed some of them.

- removed the '-rm -it' flag since I don't know the benefit of removing the containers every time
- Adding support for .env file to hold passwords and stuff
- removed the "quotes" from the docker-run_ps1, since it was failing to load that path on windows10
A couple of things I changed a couple of months ago. Stashing them ca…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant