Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I modified the project a lil' bit to support the usage of an .env file where you could store passwords and such.
Also created the docker-compose file for people using the composer (just seems faster for me to jump in a repo and hit:
docker-compose up -d
)This required:
However:
The are other commits that I've made over time included in this merge request that are not necessarily needed, like:
echo "Running as user : $(whoami)"
- added an extra space.I either did not want to change those in my repo since I use them (variables) or I did not want to cherry pick where I added extra spaces if the effort is not required. Thus, I'm submitting this 'as is'. Works fine on my instances. Might serve as inspiration to others even if this gets rejected. I see that you don't use .ENV on your dedicated server projects but having this would provide a higher level of abstractization and allow you to recycle stuff easier (like the Valheim server).