[gui] Fix non-deterministic GUI tests

web/server/codechecker_server/api/product_server.py

@@ -470,8 +470,9 @@ def editProduct(self, product_id, new_config):
                         codechecker_api_shared.ttypes.ErrorCode.GENERAL, msg)
 
                 if self.__server.get_product(new_config.endpoint):
-                    LOG.error("A product endpoint '/%s' is already"
-                              "configured!", product.endpoint)
+                    msg = f"A product endpoint '/{product.endpoint}' is " \
+                          f"already configured!"
+                    LOG.error(msg)
                     raise codechecker_api_shared.ttypes.RequestFailed(
                         codechecker_api_shared.ttypes.ErrorCode.GENERAL, msg)
 
@@ -597,7 +598,13 @@ def editProduct(self, product_id, new_config):
                 LOG.info("Product change requires database reconnection...")
 
                 LOG.debug("Disconnecting...")
-                self.__server.remove_product(old_endpoint)
+                try:
+                    # Because of the process pool it is possible that in the
+                    # local cache of the current process the product with the
+                    # old endpoint is not found and it will raise an exception.
+                    self.__server.remove_product(old_endpoint)
+                except ValueError:
+                    pass
 
                 LOG.debug("Connecting new settings...")
                 self.__server.add_product(product)

web/server/vue-cli/e2e/pages/product.js

@@ -3,6 +3,8 @@ const commands = {
     this
       .click("@editAnnouncementBtn");
 
+    this.expect.element("@overlay").to.be.visible.before(5000);
+
     this.expect.section("@editAnnouncementDialog")
       .to.be.visible.before(5000);
 
@@ -13,13 +15,17 @@ const commands = {
     this.expect.section("@editAnnouncementDialog")
       .to.not.be.present.before(5000);
 
+    this.expect.element("@overlay").to.not.be.present.before(5000);
+
     return this;
   },
 
   showGlobalPermissionsDialog() {
     this
       .click("@editGlobalPermissionBtn");
 
+    this.expect.element("@overlay").to.be.visible.before(5000);
+
     this.expect.section("@editGlobalPermissionsDialog")
       .to.be.visible.before(5000);
 
@@ -32,6 +38,8 @@ const commands = {
     this.expect.section("@editGlobalPermissionsDialog")
       .to.not.be.present.before(5000);
 
+    this.expect.element("@overlay").to.not.be.present.before(5000);
+
     return this;
   },
 
@@ -80,21 +88,12 @@ const commands = {
     this
       .click("@newProductBtn");
 
+    this.expect.element("@overlay").to.be.visible.before(5000);
     this.expect.section("@productDialog").to.be.visible;
 
     return this;
   },
 
-  closeNewProductDialog() {
-    this.section.productDialog
-      .waitForElementVisible("@closeBtn")
-      .click("@closeBtn", () => {
-        this.expect.section("@productDialog").to.not.be.present.before(4000);
-      });
-
-    return this;
-  },
-
   fillNewProductData(props={}) {
     const section = this.section.productDialog;
 
@@ -165,8 +164,9 @@ const commands = {
   },
 
   saveProduct() {
-    this.section.productDialog
-      .click("@confirmBtn");
+    this.section.productDialog.click("@confirmBtn");
+
+    this.waitForElementNotPresent("@progressBar", 5000);
 
     return this;
   },
@@ -175,11 +175,15 @@ const commands = {
     this.click("@removeBtn");
 
     this.expect.section("@removeProductDialog").to.be.visible.before(5000);
+    this.expect.element("@overlay").to.be.visible.before(5000);
 
     this.section.removeProductDialog
       .waitForElementVisible("@confirmBtn")
       .click("@confirmBtn");
 
+    this.waitForElementNotPresent("@progressBar", 5000);
+    this.expect.element("@overlay").to.not.be.present.before(5000);
+
     return this;
   },
 
@@ -229,7 +233,8 @@ module.exports = {
     searchInput: ".v-toolbar__content input[type='text']",
     progressBar: ".v-data-table__progress",
     editBtn: "tr .edit-btn",
-    removeBtn: "tr .remove-btn"
+    removeBtn: "tr .remove-btn",
+    overlay: ".v-overlay.v-overlay--active"
   },
   sections: {
     editAnnouncementDialog: {
@@ -252,7 +257,7 @@ module.exports = {
         checkBox: ".v-input--checkbox",
         cancelBtn: ".cancel-btn",
         confirmBtn: ".confirm-btn",
-        closeBtn: ".title button"
+        closeBtn: ".close-btn"
       }
     },
     productDialog: {

web/server/vue-cli/e2e/pages/report.js

@@ -125,7 +125,8 @@ module.exports = {
     setCleanupPlanBtn: ".set-cleanup-plan-btn",
     expandBtn: "button.v-data-table__expand-icon",
     selectReportCheckbox: "tbody .v-simple-checkbox",
-    selectAllReportCheckbox: "thead .v-simple-checkbox"
+    selectAllReportCheckbox: "thead .v-simple-checkbox",
+    overlay: ".v-overlay.v-overlay--active"
   },
   sections: {
     baselineRunFilter: createRunFilterSection("#run"),

web/server/vue-cli/e2e/pages/reportDetail.js

@@ -67,7 +67,8 @@ module.exports = {
     selectSameReport: ".select-same-report",
     reportStepMsg: ".report-step-msg",
     toggleBlameViewBtn: ".toggle-blame-view-btn",
-    blameCommitInfo: ".blame-commit-info"
+    blameCommitInfo: ".blame-commit-info",
+    overlay: ".v-overlay.v-overlay--active"
   },
   commands: [ commands ],
   sections: {

web/server/vue-cli/e2e/pages/runs.js

@@ -41,6 +41,7 @@ module.exports = {
     deleteSelectedRunsBtn: ".delete-run-btn",
     diffSelectedRunsBtn: ".diff-runs-btn",
     expandBtn: "button.v-data-table__expand-icon",
+    overlay: ".v-overlay.v-overlay--active",
   },
   sections: {
     table: {

web/server/vue-cli/e2e/specs/products.js

@@ -102,6 +102,8 @@ module.exports = {
       })
       .saveProduct();
 
+    product.expect.element("@overlay").to.not.be.present.before(5000);
+
     product
       .filterProducts("Test")
       .editProduct()
@@ -115,8 +117,10 @@ module.exports = {
       })
       .saveProduct();
 
-    product
-      .removeProduct();
+    product.expect.section("@productDialog").to.not.be.present.before(4000);
+    product.expect.element("@overlay").to.not.be.present.before(5000);
+
+    product.removeProduct();
   },
 
   "sort products" (browser) {

web/server/vue-cli/e2e/specs/reportDetail.js

@@ -1,5 +1,7 @@
 module.exports = {
   before(browser) {
+    browser.resizeWindow(1600, 1000);
+
     const login = browser.page.login();
 
     const reportDetailPage = browser.page.reportDetail();
@@ -68,6 +70,8 @@ module.exports = {
     reportDetailPage.expect.section(changeReviewStatusMessageDialog)
       .to.be.visible.before(5000);
 
+    reportDetailPage.expect.element("@overlay").to.be.visible.before(5000);
+
     // Set the message and save.
     const message = "Test";
     changeReviewStatusMessageDialog
@@ -85,6 +89,7 @@ module.exports = {
     reportDetailPage.click("@page");
     reportDetailPage.expect.section(reviewStatusMessageMenu)
       .to.be.not.present.before(5000);
+    reportDetailPage.expect.element("@overlay").to.not.be.present.before(5000);
   },
 
   "change review status without message" (browser) {
@@ -106,6 +111,8 @@ module.exports = {
     reportDetailPage.expect.section(changeReviewStatusMessageDialog)
       .to.be.visible.before(5000);
 
+    reportDetailPage.expect.element("@overlay").to.be.visible.before(5000);
+
     // Clear the message.
     changeReviewStatusMessageDialog
       .clearAndSetValue("@message", "", changeReviewStatusMessageDialog)
@@ -146,6 +153,8 @@ module.exports = {
     reportDetailPage.expect.section(editCommentDialog)
       .to.be.visible.before(5000);
 
+    reportDetailPage.expect.element("@overlay").to.be.visible.before(5000);
+
     editCommentDialog
       .clearAndSetValue("@message", newMessage, editCommentDialog);
 
@@ -161,6 +170,7 @@ module.exports = {
     userCommentSection.click("@removeBtn");
     reportDetailPage.expect.section(removeCommentDialog)
       .to.be.visible.before(5000);
+    reportDetailPage.expect.element("@overlay").to.be.visible.before(5000);
 
     removeCommentDialog.click("@removeBtn");
 

web/server/vue-cli/e2e/specs/reports.js

@@ -182,11 +182,14 @@ module.exports = {
 
     section.click("@input");
     reportPage.expect.section(dateDialog).to.be.visible.before(5000);
+    reportPage.expect.element("@overlay").to.be.visible.before(5000);
 
     dateDialog
       .click("@date")
       .click("@ok");
 
+    reportPage.expect.element("@overlay").to.not.be.present.before(5000);
+
     section.click("@clearBtn");
 
     reportPage
@@ -272,11 +275,14 @@ module.exports = {
 
     section.click("@input");
     reportPage.expect.section(dateDialog).to.be.visible.before(5000);
+    reportPage.expect.element("@overlay").to.be.visible.before(5000);
 
     dateDialog
       .click("@date")
       .click("@ok");
 
+    reportPage.expect.element("@overlay").to.not.be.present.before(5000);
+
     section.click("@clearBtn");
 
     await reportPage.pause(500);
@@ -440,27 +446,34 @@ module.exports = {
     dialogSection.click("@newComponentBtn");
     reportPage.expect.section(newComponentDialog).to.be.visible.before(5000);
 
+    reportPage.expect.element("@overlay").to.be.visible.before(5000);
+
     let [ name, value, description ] = [ "e2e", "+*", "Test" ];
     newComponentDialog
       .clearAndSetValue("@name", name, newComponentDialog)
       .clearAndSetValue("@value", value, newComponentDialog)
       .clearAndSetValue("@description", description, newComponentDialog)
       .click("@saveBtn");
 
+    reportPage.expect.element("@overlay").to.not.be.present.before(5000);
+
     dialogSection.api.elements("@tableRows", (elements) => {
       browser.assert.ok(elements.result.value.length === 1);
     });
 
     // Edit component.
     dialogSection.click({ selector: "@editBtn", index: 0 });
     reportPage.expect.section(newComponentDialog).to.be.visible.before(5000);
+    reportPage.expect.element("@overlay").to.be.visible.before(5000);
 
     [ value, description ] = [ "+*\n-dummy", "Renamed" ];
     newComponentDialog
       .clearAndSetValue("@value", value, newComponentDialog)
       .clearAndSetValue("@description", description, newComponentDialog)
       .click("@saveBtn");
 
+    reportPage.expect.element("@overlay").to.not.be.present.before(5000);
+
     dialogSection.api.elements("@tableRows", (elements) => {
       browser.assert.ok(elements.result.value.length === 1);
     });
@@ -498,6 +511,8 @@ module.exports = {
     reportPage.expect.section(removeComponentDialog)
       .to.be.visible.before(5000);
 
+    reportPage.expect.element("@overlay").to.be.visible.before(5000);
+
     removeComponentDialog.click("@confirmBtn");
 
     dialogSection
@@ -529,26 +544,32 @@ module.exports = {
     dialogSection.waitForElementVisible("@newCleanupPlanBtn")
     dialogSection.click("@newCleanupPlanBtn");
     reportPage.expect.section(newCleanupPlanDialog).to.be.visible.before(5000);
+    reportPage.expect.element("@overlay").to.be.visible.before(5000);
 
     let [ name, description ] = [ "e2e", "Test" ];
     newCleanupPlanDialog
       .clearAndSetValue("@name", name, newCleanupPlanDialog)
       .clearAndSetValue("@description", description, newCleanupPlanDialog)
       .click("@saveBtn");
 
+    reportPage.expect.element("@overlay").to.not.be.present.before(5000);
+
     dialogSection.api.elements("@tableRows", (elements) => {
       browser.assert.ok(elements.result.value.length === 1);
     });
 
     // Edit cleanup plan.
     dialogSection.click({ selector: "@editCleanupPlanBtn", index: 0 });
     reportPage.expect.section(newCleanupPlanDialog).to.be.visible.before(5000);
+    reportPage.expect.element("@overlay").to.be.visible.before(5000);
 
     [ description ] = [ "Renamed" ];
     newCleanupPlanDialog
       .clearAndSetValue("@description", description, newCleanupPlanDialog)
       .click("@saveBtn");
 
+    reportPage.expect.element("@overlay").to.not.be.present.before(5000);
+
     dialogSection.api.elements("@tableRows", (elements) => {
       browser.assert.ok(elements.result.value.length === 1);
     });
@@ -641,6 +662,8 @@ module.exports = {
     reportPage.expect.section(removeCleanupPlanDialog)
       .to.be.visible.before(5000);
 
+    reportPage.expect.element("@overlay").to.be.visible.before(5000);
+
     removeCleanupPlanDialog.click("@confirmBtn");
 
     dialogSection
@@ -692,18 +715,23 @@ module.exports = {
 
     section.click("@from");
     reportPage.expect.section(fromDateDialog).to.be.visible.before(5000);
+    reportPage.expect.element("@overlay").to.be.visible.before(5000);
 
     fromDateDialog
       .click("@date")
       .click("@ok");
 
+    reportPage.expect.element("@overlay").to.not.be.present.before(5000);
+
     section.click("@to");
     reportPage.expect.section(toDateDialog).to.be.visible.before(5000);
+    reportPage.expect.element("@overlay").to.be.visible.before(5000);
 
     toDateDialog
       .click("@date")
       .click("@ok");
 
+    reportPage.expect.element("@overlay").to.not.be.present.before(5000);
     section.click("@clearBtn");
 
     reportPage
@@ -720,18 +748,24 @@ module.exports = {
 
     section.click("@from");
     reportPage.expect.section(fromDateDialog).to.be.visible.before(5000);
+    reportPage.expect.element("@overlay").to.be.visible.before(5000);
 
     fromDateDialog
       .click("@date")
       .click("@ok");
 
+    reportPage.expect.element("@overlay").to.not.be.present.before(5000);
+
     section.click("@to");
     reportPage.expect.section(toDateDialog).to.be.visible.before(5000);
+    reportPage.expect.element("@overlay").to.be.visible.before(5000);
 
     toDateDialog
       .click("@date")
       .click("@ok");
 
+    reportPage.expect.element("@overlay").to.not.be.present.before(5000);
+
     section.click("@clearBtn");
 
     reportPage