Merge pull request Ericsson#4254 from bruntib/cleanup_comments

[db] Faster query for comment garbage collection
Discookie · Jun 4, 2024 · bddbdf7 · bddbdf7
2 parents 0610134 + 1e5d423
commit bddbdf7
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/web/server/codechecker_server/database/db_cleanup.py b/web/server/codechecker_server/database/db_cleanup.py
@@ -133,12 +133,14 @@ def remove_unused_comments(product):
         LOG.debug("[%s] Garbage collection of dangling comments started...",
                   product.endpoint)
         try:
-            report_hashes = session.query(Report.bug_id) \
-                .group_by(Report.bug_id) \
+            sub = session.query(Comment.id) \
+                .join(Report,
+                      Comment.bug_hash == Report.bug_id,
+                      isouter=True) \
+                .filter(Report.id.is_(None)) \
                 .subquery()
-
             count = session.query(Comment) \
-                .filter(Comment.bug_hash.notin_(report_hashes)) \
+                .filter(Comment.id.in_(sub)) \
                 .delete(synchronize_session=False)
             if count:
                 LOG.debug("%d dangling comments deleted.", count)