Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asserting downloaded file content and more changes #37

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

szymsza
Copy link
Contributor

@szymsza szymsza commented Nov 27, 2024

I added four changes:

  1. I added resource files big-gradient.jpg for a large image file and short-text.txt for a short text file. I use these in the SOP PoCs and I assume files like this can be useful for different PoCs in general.
  2. I enabled directory indexing of screenshots - navigating to /screenshots/ makes it possible to view all screenshots in the browser. Until now, I had to clumsily copy the files from the server to view them...
  3. I added REPORT_LEAK command to the script which behaves as expected and makes interaction scripts slightly more readable
  4. I added ASSERT_FILE_CONTAINS file content command which checks if the downloaded file contains the given content (as a substring) and continues the evaluation only if it does. Failing this assertion is still considered sane behaviour and the exact reason for failing is included as a query parameter in the bughog_sanity_check=OK report. I chose ASSERT_FILE_CONTAINS instead of, e.g., REPORT_LEAK_IF_FILE_CONTAINS so that the user has more freedom to choose what to do after checking the file content (e.g., download another file and report a leak only if both files contain some string).

@szymsza szymsza changed the title Dev jakub Asserting downloaded file content and more changes Nov 27, 2024
@szymsza
Copy link
Contributor Author

szymsza commented Dec 4, 2024

I added two new commands

  • NEW_TAB url - opens the URL in a new tab instead of a new window (faster + reopening the browser can mess with state, e.g., cookies)
  • OPEN_FILE filename - opens a downloaded file in the browser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant