Skip to content

Commit

Permalink
imagebuilder: properly escape single quotes in device titles
Browse files Browse the repository at this point in the history
The name "Plat'Home OpenBlocks AX3" causes the imagebuilders "make info"
command to fail with:

    bash: -c: line 0: syntax error near unexpected token `('
    bash: -c: line 0: `echo;  [...]'
    Makefile:99: recipe for target '_call_info' failed

Properly escape single quotes to avoid breaking the echo commands.

Signed-off-by: Jo-Philipp Wich <[email protected]>
  • Loading branch information
jow- committed Jan 26, 2017
1 parent b94177e commit 6cb8e30
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion target/imagebuilder/files/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ include $(INCLUDE_DIR)/target.mk

USER_PROFILE ?= $(firstword $(PROFILE_NAMES))
PROFILE_LIST = $(foreach p,$(PROFILE_NAMES), \
echo '$(patsubst DEVICE_%,%,$(p)):'; $(if $($(p)_NAME),echo ' $($(p)_NAME)'; ) echo ' Packages: $($(p)_PACKAGES)'; \
echo '$(patsubst DEVICE_%,%,$(p)):'; $(if $($(p)_NAME),echo ' $(subst ','"'"',$($(p)_NAME))'; ) echo ' Packages: $($(p)_PACKAGES)'; \
)

.profiles.mk: .targetinfo
Expand Down

0 comments on commit 6cb8e30

Please sign in to comment.