Fix tip position when tour targeted element has fixed css position

DmitriyKomanov · Sep 26, 2017 · 642c739 · 642c739
1 parent ac92287
commit 642c739
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 2 deletions.
diff --git a/build/js/bootstrap-tour-standalone.js b/build/js/bootstrap-tour-standalone.js
@@ -1275,6 +1275,9 @@
       }).popover('show');
       $tip = $element.data('bs.popover') ? $element.data('bs.popover').tip() : $element.data('popover').tip();
       $tip.attr('id', step.id);
+      if ($element.css('position' === 'fixed')) {
+        $tip.css('position', 'fixed');
+      }
       this._focus($tip, $element, step.next < 0);
       this._reposition($tip, step);
       if (isOrphan) {

diff --git a/build/js/bootstrap-tour-standalone.min.js b/build/js/bootstrap-tour-standalone.min.js
diff --git a/build/js/bootstrap-tour.js b/build/js/bootstrap-tour.js
@@ -585,6 +585,9 @@
       }).popover('show');
       $tip = $element.data('bs.popover') ? $element.data('bs.popover').tip() : $element.data('popover').tip();
       $tip.attr('id', step.id);
+      if ($element.css('position' === 'fixed')) {
+        $tip.css('position', 'fixed');
+      }
       this._focus($tip, $element, step.next < 0);
       this._reposition($tip, step);
       if (isOrphan) {

diff --git a/build/js/bootstrap-tour.min.js b/build/js/bootstrap-tour.min.js
diff --git a/src/coffee/bootstrap-tour.coffee b/src/coffee/bootstrap-tour.coffee
@@ -524,6 +524,7 @@
       # Tip adjustment
       $tip = if $element.data 'bs.popover' then $element.data('bs.popover').tip() else $element.data('popover').tip()
       $tip.attr 'id', step.id
+      $tip.css 'position', 'fixed' if $element.css 'position' is 'fixed'
 
       @_focus $tip, $element, step.next < 0
       @_reposition $tip, step

diff --git a/src/docs/assets/js/bootstrap-tour.js b/src/docs/assets/js/bootstrap-tour.js
@@ -585,6 +585,9 @@
       }).popover('show');
       $tip = $element.data('bs.popover') ? $element.data('bs.popover').tip() : $element.data('popover').tip();
       $tip.attr('id', step.id);
+      if ($element.css('position' === 'fixed')) {
+        $tip.css('position', 'fixed');
+      }
       this._focus($tip, $element, step.next < 0);
       this._reposition($tip, step);
       if (isOrphan) {

diff --git a/test/bootstrap-tour.js b/test/bootstrap-tour.js
@@ -585,6 +585,9 @@
       }).popover('show');
       $tip = $element.data('bs.popover') ? $element.data('bs.popover').tip() : $element.data('popover').tip();
       $tip.attr('id', step.id);
+      if ($element.css('position' === 'fixed')) {
+        $tip.css('position', 'fixed');
+      }
       this._focus($tip, $element, step.next < 0);
       this._reposition($tip, step);
       if (isOrphan) {